Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ext4: fix log printing of ext4_mb_regular_allocator()
To:     Andreas Dilger <adilger@dilger.ca>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
References: <131a608b-0c8a-1a2d-57ee-4263cfcdd5a2@gmail.com>
 <8A79C6DA-5C0F-4B4F-9EEE-E272993AD0FC@dilger.ca>
From:   brookxu <brookxu.cn@gmail.com>
Message-ID: <fbfffb3d-e7a1-ccef-6247-2599522671da@gmail.com>
Date:   Fri, 14 Aug 2020 09:14:04 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <8A79C6DA-5C0F-4B4F-9EEE-E272993AD0FC@dilger.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

This suggestion is good, I try to update it in the next version.

thanks.

Andreas Dilger wrote on 2020/8/13 3:36:
> On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@gmail.com> wrote:
>>
>> Fix log printing of ext4_mb_regular_allocator()，it may be an
>> unintentional behavior.
>>
>> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> 
> The debug message would probably be more useful if it included some
> actual information (PID, status, fe_group, fe_start, fe_len), but
> that isn't necessarily a problem with this patch itself.
> 
> Reviewed-by: Andreas Dilger <adilger@diger.ca>
> 
> 
>> ---
>> fs/ext4/mballoc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index 5d4a1be..b0da525 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -2324,15 +2324,14 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
>> 		 * We've been searching too long. Let's try to allocate
>> 		 * the best chunk we've found so far
>> 		 */
>> -
>> 		ext4_mb_try_best_found(ac, &e4b);
>> 		if (ac->ac_status != AC_STATUS_FOUND) {
>> 			/*
>> 			 * Someone more lucky has already allocated it.
>> 			 * The only thing we can do is just take first
>> 			 * found block(s)
>> -			printk(KERN_DEBUG "EXT4-fs: someone won our chunk\n");
>> 			 */
>> +			mb_debug(sb, "EXT4-fs: someone won our chunk\n");
>> 			ac->ac_b_ex.fe_group = 0;
>> 			ac->ac_b_ex.fe_start = 0;
>> 			ac->ac_b_ex.fe_len = 0;
>> --
>> 1.8.3.1
> 
> 
> Cheers, Andreas
> 
> 
> 
> 
>