Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Aug 2020 09:04:04 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jiang Ying <jiangying8582@126.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, wanglong19@meituan.com,
        heguanjun@meituan.com, jack@suse.cz
Subject: Re: [PATCH v4] ext4: fix direct I/O read error
Message-ID: <20200814080404.GA14135@infradead.org>
References: <1596613234-174664-1-git-send-email-jiangying8582@126.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1596613234-174664-1-git-send-email-jiangying8582@126.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 05, 2020 at 03:40:34PM +0800, Jiang Ying wrote:
> This patch is used to fix ext4 direct I/O read error when
> the read size is not aligned with block size.
> 
> Then, I will use a test to explain the error.
> 
> (1) Make a file that is not aligned with block size:
> 	$dd if=/dev/zero of=./test.jar bs=1000 count=3
> 
> (2) I wrote a source file named "direct_io_read_file.c" as following:

Can you please add your reproducer to xfstests?

Thanks!