Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   =?utf-8?B?5aec6L+O?= <jiangying8582@126.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v4] ext4: fix direct I/O read error
Date:   Fri, 14 Aug 2020 16:38:16 +0800
Message-Id: <7C2EEB3C-3007-469A-B3E6-B810AFB6E983@126.com>
References: <20200814080404.GA14135@infradead.org>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, wanglong19@meituan.com,
        heguanjun@meituan.com, jack@suse.cz
In-Reply-To: <20200814080404.GA14135@infradead.org>
To:     Christoph Hellwig <hch@infradead.org>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Ok=EF=BC=8CI will make time to do it.

=E5=8F=91=E8=87=AA=E6=88=91=E7=9A=84iPhone

> =E5=9C=A8 2020=E5=B9=B48=E6=9C=8814=E6=97=A5=EF=BC=8C=E4=B8=8B=E5=8D=884:0=
4=EF=BC=8CChristoph Hellwig <hch@infradead.org> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> =EF=BB=BFOn Wed, Aug 05, 2020 at 03:40:34PM +0800, Jiang Ying wrote:
>> This patch is used to fix ext4 direct I/O read error when
>> the read size is not aligned with block size.
>>=20
>> Then, I will use a test to explain the error.
>>=20
>> (1) Make a file that is not aligned with block size:
>>    $dd if=3D/dev/zero of=3D./test.jar bs=3D1000 count=3D3
>>=20
>> (2) I wrote a source file named "direct_io_read_file.c" as following:
>=20
> Can you please add your reproducer to xfstests?
>=20
> Thanks!