Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Aug 2020 14:18:48 -0400
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     brookxu <brookxu.cn@gmail.com>
Cc:     adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: optimize the implementation of ext4_mb_good_group()
Message-ID: <20200818181848.GD34125@mit.edu>
References: <e20b2d8f-1154-adb7-3831-a9e11ba842e9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e20b2d8f-1154-adb7-3831-a9e11ba842e9@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 07, 2020 at 10:01:39PM +0800, brookxu wrote:
> It might be better to adjust the code in two places:
> 1. Determine whether grp is currupt or not should be placed first.
> 2. (cr<=2 && free <ac->ac_g_ex.fe_len)should may belong to the crx
>    strategy, and it may be more appropriate to put it in the
>    subsequent switch statement block. For cr1, cr2, the conditions
>    in switch potentially realize the above judgment. For cr0, we
>    should add (free <ac->ac_g_ex.fe_len) judgment, and then delete
>    (free / fragments) >= ac->ac_g_ex.fe_len), because cr0 returns
>    true by default.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Thanks, applied.

					- Ted