Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <C0C75F3E-F34B-4DB9-B139-C93694EF693D@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_B4C19C5C-A0E1-4B4F-A1FC-6EB055F4EF04";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v5 1/2] ext4: reorganize if statement of
 ext4_mb_release_context()
Date:   Mon, 24 Aug 2020 15:34:49 -0600
In-Reply-To: <5439ac6f-db79-ad68-76c1-a4dda9aa0cc3@gmail.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Ritesh Harjani <riteshh@linux.ibm.com>,
        Jan Kara <jack@suse.cz>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     brookxu <brookxu.cn@gmail.com>
References: <530dadc7-7bee-6d90-38b8-3af56c428297@gmail.com>
 <20200815133212.8D164A4057@d06av23.portsmouth.uk.ibm.com>
 <5439ac6f-db79-ad68-76c1-a4dda9aa0cc3@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_B4C19C5C-A0E1-4B4F-A1FC-6EB055F4EF04
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Aug 17, 2020, at 1:36 AM, brookxu <brookxu.cn@gmail.com> wrote:
>=20
> Reorganize the if statement of ext4_mb_release_context(), make it
> easier to read.
>=20
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/mballoc.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 70b110f..51f37f1 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4567,20 +4567,19 @@ static int ext4_mb_release_context(struct =
ext4_allocation_context *ac)
> 			pa->pa_free -=3D ac->ac_b_ex.fe_len;
> 			pa->pa_len -=3D ac->ac_b_ex.fe_len;
> 			spin_unlock(&pa->pa_lock);
> -		}
> -	}
> -	if (pa) {
> -		/*
> -		 * We want to add the pa to the right bucket.
> -		 * Remove it from the list and while adding
> -		 * make sure the list to which we are adding
> -		 * doesn't grow big.
> -		 */
> -		if ((pa->pa_type =3D=3D MB_GROUP_PA) && =
likely(pa->pa_free)) {
> -			spin_lock(pa->pa_obj_lock);
> -			list_del_rcu(&pa->pa_inode_list);
> -			spin_unlock(pa->pa_obj_lock);
> -			ext4_mb_add_n_trim(ac);
> +
> +			/*
> +			 * We want to add the pa to the right bucket.
> +			 * Remove it from the list and while adding
> +			 * make sure the list to which we are adding
> +			 * doesn't grow big.
> +			 */
> +			if (likely(pa->pa_free)) {
> +				spin_lock(pa->pa_obj_lock);
> +				list_del_rcu(&pa->pa_inode_list);
> +				spin_unlock(pa->pa_obj_lock);
> +				ext4_mb_add_n_trim(ac);
> +			}
> 		}
> 		ext4_mb_put_pa(ac, ac->ac_sb, pa);
> 	}
> --
> 1.8.3.1
>=20
>=20


Cheers, Andreas


--Apple-Mail=_B4C19C5C-A0E1-4B4F-A1FC-6EB055F4EF04
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl9EMnkACgkQcqXauRfM
H+DINhAApbmuErKVkyGroY7x2EZI5rxfhDQWmJv+2wZ36zz7zNJDzmRdn4sCdgX0
piDJGS2K57tk7rjT0LReiNpe/dMjfF0LOgm7lgj1Qr20HDXVoo6C/D0qUW6AAKTD
NqiFNEAQxOeVEpw1+KjA2KNqpvQdeyF6cAAwxAZGqIqYF55LqnWhkRuTzLE86jKK
Xal+KHd4VoflZP6J7L1m5k9QIUXJqSWb//OxdPsPTP5cWKoW7BCv+4AGbXWvfcBb
KgFvTCLKgZGleo8qWW4mxzG1bduIQCT8yVEKaJx2RZgYZc1cGtRMTmyJH8J66ibY
4NMW83o5KPjhsOxB+mzujZb1sSrkLpgEtfH9MyzF0+81C5YdyBBJCEXrFoIjOQmn
dNNJzKmswURVpHTeeZ44sSRAxq5PpuKpcHJb1msRLo8/tyTH2qJKKW2jPXf0eNli
4LBL1NLSq84bCR2YTgBWrXa6CUeQxLvwRcfZzOreeA0G6Jwvr6lZwTOXLXXDko6b
0fIG/y5BpU62+rHd51AHG0GzbesN2hSwf5sxJKon5p02E+JlkFadww4NBfK1dUe7
Dt3WBHl9w3FFF4iubQaySy94KEweoWIGJhboCdTa9LH1yXNlkeOz5dzp7JHchk+F
xRVZbj/HpdI1txjxMfK5BzjkBzl1wB43cSoLzKeZhYkZ8Aa0aso=
=o8kZ
-----END PGP SIGNATURE-----

--Apple-Mail=_B4C19C5C-A0E1-4B4F-A1FC-6EB055F4EF04--