Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2820392pxa; Tue, 25 Aug 2020 04:23:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUJks2EgUX+pS6lHdZD+kLgjr3U9NGnchYeIDPa8TIWtOno0+CxBdY8NUF9uKghvST+IN4 X-Received: by 2002:a17:906:fb85:: with SMTP id lr5mr10218307ejb.328.1598354592759; Tue, 25 Aug 2020 04:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598354592; cv=none; d=google.com; s=arc-20160816; b=V3uDAwyWBe2/1UZqHn6CsTG8653FmENSF+UvzCiZfNfjLecFav5Mq34P4TRZvdKTZJ 0mu5Qyx1gP9ULgEybPh34SWG4ZidslQu3i5QZnnU8s7YGEPFyMU/+StwZJecO46POg1n MqZnjelVxkISW8xGICUGuoLcAzljInQ6V5k5FvTWXVHodPJb6EvslR7DIm9U0oSJ69Bm z2V2Xi0K/mszDyFSXah5Q6Iq+MqePqaLWRmhPuA69sZCZr9saKfb3CbUsk7sRBz06M6n /TWX+wLKK0hBd7aFbpVLTlb5arPEz7IZTi9yO4pUeUNYCYlgvMizxFk1QShStTPbv7lk 8l6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Y8tYGIcaslAkdQtxJehqh9yrMuWuEgxVcXkf8U1Ien0=; b=n6P2JuDrUa554JR+m5RpI8LIm56mbosd1DITf6DCkVkDcbSH6dag62GtnY0+lYPnEB vcNNscMepotrUiIdVYjKmmhyYL37JrPmTbsVtr8Dq920xDQ2+6QNVQdbAezVyxavNK1s 2VAf5VIc3tp87AhixpvBuGc85nkZfihot4XIGcLhkpIqS1RABpbmYmQUBx4cx99l8uLp cuMhcc/WHWDzxohPUUnzuwIiFzJga4qpK4vu3LCuexpSwsJd5e67+Mon0CnWvflWbc1h K6DYN8Y9/WybTnKEe9tbO/tD36U6f9lp20c49hxV76Y784r9YRlCkDzo0S9oidsiLtY0 qjiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=BmmrGemw; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf17si4047884ejb.351.2020.08.25.04.22.40; Tue, 25 Aug 2020 04:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=BmmrGemw; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbgHYLWP (ORCPT + 99 others); Tue, 25 Aug 2020 07:22:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729986AbgHYLWK (ORCPT ); Tue, 25 Aug 2020 07:22:10 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD21DC061574; Tue, 25 Aug 2020 04:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y8tYGIcaslAkdQtxJehqh9yrMuWuEgxVcXkf8U1Ien0=; b=BmmrGemwTGvO1CAjmKE8PH/rPA PTXrUHTxPJF7GmOjtRCH7f8grW8lwB6rJjJfy7jMzn0UDbo36rSZ8cyb0fuCUjRYS3aJka9N83aeW gEEcWUCLOTMsIp77S3OTV/+MY3rKkD4op6kFS6JDJTGyujW+GcaWPcOkfGjOdw6tjDhJIeSqY315U 2K8yMaGJfs6ZMYlBa1ENazOmRi53m/jpF/gWFy3zP5z5Ely2V5p/8csuCVbQjiuoBlfQKdqve47z3 EOQ3CCMTAEWrekdEH2oDgFNSGAnNiUIOQDf5oU5wqS3ob9/zWck1S4yz2ch+kJe79vYaLeRZDwKhv QBazWawA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAX1b-0007kx-Bg; Tue, 25 Aug 2020 11:21:59 +0000 Date: Tue, 25 Aug 2020 12:21:59 +0100 From: Christoph Hellwig To: Yuxuan Shui Cc: Christoph Hellwig , "Darrick J. Wong" , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca Subject: Re: [PATCH] iomap: iomap_bmap should accept unwritten maps Message-ID: <20200825112159.GA29726@infradead.org> References: <20200505183608.10280-1-yshuiv7@gmail.com> <20200505193049.GC5694@magnolia> <20200825102040.GA15394@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 25, 2020 at 11:40:34AM +0100, Yuxuan Shui wrote: > Hi, > > On Tue, Aug 25, 2020 at 11:20 AM Christoph Hellwig wrote: > > > > On Tue, Aug 25, 2020 at 10:26:14AM +0100, Yuxuan Shui wrote: > > > Hi, > > > > > > Do we actually want to fix this bug or not? There are a number of > > > people actually seeing this bug. > > > > bmap should not succeed for unwritten extents. > > Why not? Unwritten extents are still allocated extents. Because you can't read from or write to them.