Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3111257pxk; Mon, 7 Sep 2020 03:36:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKh3ytu7EEMXCvCZUhh6XqRoU+NKXFB0wcmAHrfVRZg1wMrIxYChUu/kAwW6hhjAm3fPIC X-Received: by 2002:a17:906:4b41:: with SMTP id j1mr19840920ejv.1.1599475014721; Mon, 07 Sep 2020 03:36:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599475014; cv=none; d=google.com; s=arc-20160816; b=yevtA72Xaw0IeqFPXS2VCFnEiS4qh73dbwfBEXxXSepjmi0GecJFVc+YoO9ALfjVNo 9buRV0LwHVhFwpbaawBQF99RkQkWs41hdfw1owRGOWMSZDIjVv7LzCBZtB96eYqwbdJi ERqXJtbYHkLpxlkeNg9X0Dy0dLJBo2SOpxg8WE3W+ZRX7ldCrObiV9Q78iHtYaAF3wqp Ki6ELhHeXeNsiG765L+XsjjdBT3pMWrxpr6vROvXBHEZccUCtPBrmwj89ZrjQZgR1c4b kZw4h/yOoA310o0gumMrBWOOCMzbGmCK/rzVBuw788xqVkTyu2XwGsJF1vtUfdTOdYYg YgwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rZ6JrnT5kgmKMl6Osz9fwqtCuYyj9fpOzAxTUit2pbs=; b=XIC9I2+4Ev0q1sWYQ+mrlKQ4hrBT1+jfeqiAvzo3T41VIxhbQFcveaXZ2voa34tRDc +QB4M58bHFVjpugWeM1uilufsOmp+flNpVx7QKstHqwFPiayrijWk6T1abNOYbu1Gju8 JwegG09fwPS+raQJrcsHhqiLOVRSa/Kg83HG4yy2OkDaSi5ZZ4IYYpZkj1A7fa6UL8MS bXNOi+Awo9gEPnCyfvRtZxaGYGOh0/iC8Z4Hf+j3/JJAUOHB6XshtS1edKjL0EIegx+F EygI/GSZC5fCkZDSTSCrovS6lnLp58wYl91XWzfOy1cjYQjO99lF+77J4VM/FvOtzoYa CieA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si9206101edr.375.2020.09.07.03.36.24; Mon, 07 Sep 2020 03:36:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728841AbgIGKf4 (ORCPT + 99 others); Mon, 7 Sep 2020 06:35:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:42458 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728659AbgIGKfy (ORCPT ); Mon, 7 Sep 2020 06:35:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1B4C3B13F; Mon, 7 Sep 2020 10:35:51 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id DFD741E12D1; Mon, 7 Sep 2020 12:35:49 +0200 (CEST) Date: Mon, 7 Sep 2020 12:35:49 +0200 From: Jan Kara To: linux-fsdevel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , yebin , Andreas Dilger , Jens Axboe , Jan Kara Subject: Re: [PATCH 0/2 v2] bdev: Avoid discarding buffers under a filesystem Message-ID: <20200907103549.GA20428@quack2.suse.cz> References: <20200904085852.5639-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904085852.5639-1-jack@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello! On Fri 04-09-20 10:58:50, Jan Kara wrote: > this patch set fixes problems when buffer heads are discarded under a > live filesystem (which can lead to all sorts of issues like crashes in case > of ext4). Patch 1 drops some stale buffer invalidation code, patch 2 > temporarily gets exclusive access to the block device for the duration of > buffer cache handling to avoid interfering with other exclusive bdev user. > The patch fixes the problems for me and pass xfstests for ext4. > > Changes since v1: > * Check for exclusive access to the bdev instead of for the presence of > superblock Jens, now that Christoph has reviewed the patches (thanks Christoph!), can you pick up the patches to your tree please? Thanks! Honza -- Jan Kara SUSE Labs, CR