Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3320104pxk; Mon, 7 Sep 2020 09:26:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFUlZ3XCTir0tHTnNGAqjvqLVU834uKjxImoa4Gu7Fg1uqz8caplngbVlzKNiGLFMXIepx X-Received: by 2002:a05:6402:17f6:: with SMTP id t22mr8287154edy.374.1599495974125; Mon, 07 Sep 2020 09:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599495974; cv=none; d=google.com; s=arc-20160816; b=zqkwb7Wh23JT7TzB6+wkzvQZRB3LTFR+eNmAdEl6c0IpKOkYlMuIF2FU1CWCOV2lAS kARqHHCtH+nFyXlgWWPxJ1iGRG84mlhRMRrGH04xBXYOCMMiaZUcp/9hNZFAdkCxI/wB hkW74B+jF/43mhsN2Kr3HH5A7PAutCgcGREqACXHs55ae7DyAA6tKLAznrRrX73qpEwY hfVcRk4ZqOoCxfW3GJv7Oj4tD1LD6kithTMPu8oEEJ0e2xRU/BPG/Q6d3+GsFkQUt8x3 TmbB6PwswhP07/DwtOJsI8Y9ttgI+jvfFxTHPX7xqKB+pix/BQ0hsJkAy20sooWrL3O6 fj9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=4YsnN1303DLyqvh22K/u/PKzYPbQQRqVlMMHZW3C9us=; b=biqBpMwmlg4T/C3lq4tLjm3Ej0xIX2xeYsEc9CpXpotzEIIajG5PVvpnv8DwwSjJW+ w+eYs8sh95lKq9SqrOCHlWyhuAxyGGW556r74VHWVTC6fNQ/zXOOorKE0QnE5nTaJKcu Z85K+5VLAtwG0cqPtFpjgdkucdIg5x3b5FpeAi405B0tU2auglifxZsHJCPIpOxi38vA CWsDfRlPbLtTBREpF4lcOiYgSgP+29JDVjHrwTrgffcVbGMcszsQdsyO/oKGD+zsUlV+ 85ydzN9u/Ky1UFSaLbtwZQZTS0LT2hs2llXdqHiV+Hq4te/fH2sS62xI9Wtv2mHWJqFZ aTiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0AE+6gwe; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si1494724eds.577.2020.09.07.09.25.43; Mon, 07 Sep 2020 09:26:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0AE+6gwe; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729939AbgIGQYI (ORCPT + 99 others); Mon, 7 Sep 2020 12:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729988AbgIGQYD (ORCPT ); Mon, 7 Sep 2020 12:24:03 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA79C061575 for ; Mon, 7 Sep 2020 09:24:03 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id c196so3376962pfc.0 for ; Mon, 07 Sep 2020 09:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4YsnN1303DLyqvh22K/u/PKzYPbQQRqVlMMHZW3C9us=; b=0AE+6gwetZYIhZkP/Gn/AbnsMQFQJXBsA2WB6QCghlw0FcJWNQJA1qs4qh5J42bl1p pGhd6WQ/1r1vyg9aXGVG1TrnqpDlQ9tMVlDqMVGdNSLLfcvhuegRgHvXecypW09fh9n0 suXHGxAfp93zhwMKmeTUPzS/Vm6nTDf9/hHhkvAIHzr9kLIMVmBifDJDrcZ4KiR4tHYy +N1xNNq7iFsQhL8RbxevbOYzrzsZKDwMIiHTwkCemNcV02Z6tzGqeS0Dt+bOsuzhX6Uz ptshVA0CiE1SnNMUyXI0mVCaHShXOnDZ7KeG3WF1/T8snIoDJwwEA0wn15P0EkchJCku 9GfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4YsnN1303DLyqvh22K/u/PKzYPbQQRqVlMMHZW3C9us=; b=NhPbP0MmT9m1LLB8FDo7yoD9vTBvNRrnYMkzbsmqIo/EN8bOSVNntj0cydtzTLfjKg NZC+1pWpNjFYI09pcv551gZT+WnjDwshgyfMiiRItwBOdBZEN2xDTbPc/ZhV+13WY4Ui gn4MriApqYB/QniyJoZB74IcSQ5OfKEgbAVKXRTaaPGKq3IXqiYdPn34AuhRUrjBmNhF Ed3h4VzLc5QdFQ+IW8hJnq4hjHDKzWoCrKNdm3BcVlGKyqtTEOfD1PVWEe9ZY0eW7EKT 6nUUb/VxIYYNlNs5QZexa5sGx7py2UvhDM4/tDVmfU4Ov/ox6KqBq2H2dOqzQtzJqs5j 5B/A== X-Gm-Message-State: AOAM531KM4iHH3yugUtoylaJD3ch/uH44G5ww+5mj7ZWKohZNN0AiP4i ObAu6pu6j48MCSuzb1y8/a1KkQ== X-Received: by 2002:a62:6845:0:b029:13e:dcd:75bd with SMTP id d66-20020a6268450000b029013e0dcd75bdmr8381274pfc.12.1599495842666; Mon, 07 Sep 2020 09:24:02 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id nu14sm12450081pjb.19.2020.09.07.09.24.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2020 09:24:02 -0700 (PDT) Subject: Re: [PATCH 0/2 v2] bdev: Avoid discarding buffers under a filesystem To: Jan Kara , linux-fsdevel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , yebin , Andreas Dilger References: <20200904085852.5639-1-jack@suse.cz> <20200907103549.GA20428@quack2.suse.cz> From: Jens Axboe Message-ID: <2e287fe0-b963-0143-2a3f-617f32a67f76@kernel.dk> Date: Mon, 7 Sep 2020 10:24:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200907103549.GA20428@quack2.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 9/7/20 4:35 AM, Jan Kara wrote: > Hello! > > On Fri 04-09-20 10:58:50, Jan Kara wrote: >> this patch set fixes problems when buffer heads are discarded under a >> live filesystem (which can lead to all sorts of issues like crashes in case >> of ext4). Patch 1 drops some stale buffer invalidation code, patch 2 >> temporarily gets exclusive access to the block device for the duration of >> buffer cache handling to avoid interfering with other exclusive bdev user. >> The patch fixes the problems for me and pass xfstests for ext4. >> >> Changes since v1: >> * Check for exclusive access to the bdev instead of for the presence of >> superblock > > Jens, now that Christoph has reviewed the patches (thanks Christoph!), can > you pick up the patches to your tree please? Thanks! Yep, I applied them for 5.10. Thanks! -- Jens Axboe