Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <2A963475-D65D-4E58-9EDD-93D6784934B4@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_1895A279-0157-404F-935F-E0D4BCB0D12D";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [RFC PATCH v4 1/4] jbd2: introduce/export functions
 jbd2_journal_submit|finish_inode_data_buffers()
Date:   Mon, 28 Sep 2020 20:24:11 -0600
In-Reply-To: <20200928194103.244692-2-mfo@canonical.com>
Cc:     Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org,
        dann frazier <dann.frazier@canonical.com>
To:     Mauricio Faria de Oliveira <mfo@canonical.com>
References: <20200928194103.244692-1-mfo@canonical.com>
 <20200928194103.244692-2-mfo@canonical.com>
Precedence: bulk


--Apple-Mail=_1895A279-0157-404F-935F-E0D4BCB0D12D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Sep 28, 2020, at 1:41 PM, Mauricio Faria de Oliveira =
<mfo@canonical.com> wrote:
>=20
> Export functions that implement the current behavior done
> for an inode in journal_submit|finish_inode_data_buffers().
>=20
> No functional change.
>=20
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
> Suggested-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Jan Kara <jack@suse.cz>

A couple of minor cleanups below, but either way you could add:

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> +int jbd2_journal_finish_inode_data_buffers(struct jbd2_inode *jinode)
> +{
> +	struct address_space *mapping =3D =
jinode->i_vfs_inode->i_mapping;
> +	loff_t dirty_start =3D jinode->i_dirty_start;
> +	loff_t dirty_end =3D jinode->i_dirty_end;
> +	int ret;
> +
> +	ret =3D filemap_fdatawait_range_keep_errors(mapping, =
dirty_start, dirty_end);
> +	return ret;
> +}

(style) still prefer to wrap at 80 columns if possible.
(style) there isn't any benefit to "dirty_start" and "dirty_end" as =
locals
(style) there also isn't any benefit to "ret =3D ...; return ret"

I thought it might be coded this way because the function is changed in =
a
later patch in the series, but I couldn't find anything like that, so =
the
shorter form is just as readable, IMHO:

int jbd2_journal_finish_inode_data_buffers(struct jbd2_inode *jinode)
{
	struct address_space *mapping =3D =
jinode->i_vfs_inode->i_mapping;

	return filemap_fdatawait_range_keep_errors(mapping,
						   jinode->dirty_start,
						   jinode->dirty_end);
}

Cheers, Andreas


--Apple-Mail=_1895A279-0157-404F-935F-E0D4BCB0D12D
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl9ymssACgkQcqXauRfM
H+A3JA//cVPI2Nq606YX32v0lhT6+6dXva9pFnqnM2xa8zDLQB6iutwdLE4R1sOL
7aVtwQlxQuUxCx1sMcYVjZ8YhatwSxzxrVkYbO3yLO3L/o9k0qL5Nwjk25vKqOzm
MUbyCpNfn+pqdiExsWcWL34ERUADVuO+oCNCS/x0hm0DndvM/QxW/XCR942VM9f/
AZjaXVV7wywlgGjMjDEZvSyFZXgJkNIEUTAHCBbR5y9QaQgNGU3p8bjM/vXNO1mU
anINlRXrIAHNbhpYEaVLvlx24cNVvv+644+H4/D6xxZj2XvFiE/8DmyqINXRcq8c
39OkLZU/ExDj2wcuZ4gz4nlccDox4wj34skex9G0L+mPsHSpzIXk+VJKArHOp6Eh
xwfI6GYG+jY78rIn53Dunh/rXlCNmB+x8X0Yo+180lyYXykCb0sn93JaFO+2CJxA
UMdqofeAuVzZs6yNO//27pcsJM8/REmqfwfJCMP6r9554ww8IlgPFtxoGPCamoyZ
H/MVzdfP8JgG5bg9tBx4Cq9nmwPFmtz7ZiAbe/m3N79UNh6b7FH8prn2AvwpAOZz
ZHDtm1n/jPN09xgXqPm+uX9jNk9v3ULr/w0UMSD0Ym509MAZUl4KN/qYblnlZJWx
Y8Hl2R41p3ln1eK8+uufPjA/y1KeYrmm2IqdEtkZmT+Ms36PsSs=
=M3+F
-----END PGP SIGNATURE-----

--Apple-Mail=_1895A279-0157-404F-935F-E0D4BCB0D12D--