Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <3B21D37E-AA2D-4D54-B4C7-8D094FFB766D@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_5133FEA4-56C1-43B0-B9F4-EA1908785C2D";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] e2fsck: skip extent optimization by default
Date:   Thu, 1 Oct 2020 20:11:06 -0600
In-Reply-To: <20201001180336.GM23474@mit.edu>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     "Theodore Y. Ts'o" <tytso@MIT.EDU>
References: <1600726562-9567-1-git-send-email-adilger@whamcloud.com>
 <20201001180336.GM23474@mit.edu>
Precedence: bulk


--Apple-Mail=_5133FEA4-56C1-43B0-B9F4-EA1908785C2D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Oct 1, 2020, at 12:03 PM, Theodore Y. Ts'o <tytso@MIT.EDU> wrote:
> On Mon, Sep 21, 2020 at 04:16:02PM -0600, adilger@whamcloud.com wrote:
>> From: Andreas Dilger <adilger@whamcloud.com>
>>=20
>> The e2fsck error message:
>>=20
>>    inode nnn extent tree (at level 1) could be narrower. Optimize<y>?
>>=20
>> can be fairly verbose at times, and leads users to think that there
>> may be something wrong with the filesystem.  Basically, almost any
>> message printed by e2fsck makes users nervous when they are facing
>> other corruption, and a few thousand of these printed may hide other
>> errors.  It also isn't clear that saving a few blocks optimizing the
>> extent tree noticeably improves performance.
>>=20
>> This message has previously been annoying enough for Ted to add the
>> "-E no_optimize_extents" option to disable it.  Just enable this
>> option by default, similar to the "-D" directory optimization option.
>>=20
>> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
>=20
> Applying this patch causes a whole bunch of tests fail:
>=20
> 348 tests succeeded 9 tests failed
> Tests failed: d_punch_bigalloc d_punch f_collapse_extent_tree
>      f_compress_extent_tree_level f_extent_bad_node =
f_extent_int_bad_magic
>      f_extent_leaf_bad_magic f_extent_oobounds f_quota_extent_opt

Sorry about that, I usually *do* run the tests after every patch, I'm =
not
sure why I didn't for this patch.

>> @@ -1051,6 +1053,11 @@ static errcode_t PRS(int argc, char *argv[], =
e2fsck_t *ret_ctx)
>> 	if (c)
>> 		ctx->options |=3D E2F_OPT_NOOPT_EXTENTS;
>>=20
>> +	profile_get_boolean(ctx->profile, "options", "optimize_extents",
>> +			    0, 0, &c);
>> +	if (c)
>> +		ctx->options &=3D ~E2F_OPT_NOOPT_EXTENTS;
>> +
>=20
> We already have a no_optimize_extents option supported in e2fsck.conf.
> So if we want to change the default, a simpler way to do this might be
> to edit e2fsck.conf.5.in to simply add "no_optimize_extents=3Dtrue" to
> the default version of e2fsck.conf defined by default.

Does that mean you *don't* want a refresh of this patch that fixes the
test cases?  Lukas had also been discussing how to change e2fsck so it
still fixed the inodes, but didn't print a message for each one, though
it wasn't clear to me that there is much benefit to this at all.

> As a reminder, for future changes, when we add a new tunable to
> e2fsck.conf or mke2fs.conf, the man page should be edited.

Yes, I did edit the e2fsck.8.in man page to describe the change in
default behavior.

Cheers, Andreas


--Apple-Mail=_5133FEA4-56C1-43B0-B9F4-EA1908785C2D
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl92jDoACgkQcqXauRfM
H+DU2RAAkiBjFfpTq5Qy8ILi/ITFrndgR9V0qLx8lIn1Ksz+K71msZR3jolQNzle
1l/aonECbYactt1pDSZqoCnWvr+bdQtR5VZ4HK77C6N/oRniEdFpvdnPnk8gXIK+
Dy/MaapfJN1rkHgj8oTZPLhOmVEv98PDfkog3GgWDKGAkMzXkXShwtGHibxXuAk4
ipJB1yCTTxZS5y5jZBVLvwaaHX/i8NIMSMSwCb6nAs+aLR61Pto8DP2wN4AdBMNX
GEQGiKLLxzy0V0uKJHjTURt4fTxPXYo6iUn9yhMVwA0o4g1Gr+qd6qHF0IrAGWjC
xY8jIeyWB8Vl4TjQ0pyX6UOJVtjCw2yjcNGiTzPAQA9NKj2LTCGz4CF56Hyk0Guj
9MwykZF2Bkrm7ipeM06tyk6OwjVCehTMEKVVvztqjadZnu0Ccysv6KkNDpoLwlFX
KwAheWwBhES9QVRby4UOW32NePDuJFRbh94z7HiAX+C+RaUt3l365ayPL+g07QpG
s50OakzdSUKtg1oFDw9MDUwlhBrdcehkAMYDqUY+e6capw/4BRnzxM6kLJX+qbnb
nmvXyQQLxOPLZFPFyzCNg9MjdzTpcmDLXB2mtcpEDP+Won4aaUdOxiFBTMxj67k/
SNC2o/AypcLZXNzE82FeT5AhWMqr4zbJO7L/F+TIZl0aX8ciDWA=
=eUva
-----END PGP SIGNATURE-----

--Apple-Mail=_5133FEA4-56C1-43B0-B9F4-EA1908785C2D--