Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 3 Oct 2020 01:09:29 -0400
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc:     yi.zhang@huawei.com, jack@suse.cz, linux-ext4@vger.kernel.org,
        adilger.kernel@dilger.ca
Subject: Re: [PATCH v3] ext4: Fix bdev write error check failed when mount fs
 with ro
Message-ID: <20201003050929.GL23474@mit.edu>
References: <20200928020556.710971-1-zhangxiaoxu5@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200928020556.710971-1-zhangxiaoxu5@huawei.com>
Precedence: bulk

On Sun, Sep 27, 2020 at 10:05:56PM -0400, Zhang Xiaoxu wrote:
> Consider a situation when a filesystem was uncleanly shutdown and the
> orphan list is not empty and a read-only mount is attempted. The orphan
> list cleanup during mount will fail with:
> 
> ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata
> 
> This happens because sbi->s_bdev_wb_err is not initialized when mounting
> the filesystem in read only mode and so ext4_check_bdev_write_error()
> falsely triggers.
> 
> Initialize sbi->s_bdev_wb_err unconditionally to avoid this problem.
> 
> Fixes: bc71726c7257 ("ext4: abort the filesystem if failed to async write metadata buffer")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied, thanks.

				- Ted