Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <F9799E9E-6AC8-4C66-B6C6-31CDFA8F55A6@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_412C097C-2A01-4EE1-8676-2B5C5C1FD48F";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with
 overlapped bitmaps
Date:   Wed, 7 Oct 2020 20:57:12 -0600
In-Reply-To: <20201007201424.GB15049@localhost>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Jan Kara <jack@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     Josh Triplett <josh@joshtriplett.org>
References: <CAHk-=wj-H5BYCU_kKiOK=B9sN3BtRzL4pnne2AJPyf54nQ+d=w@mail.gmail.com>
 <20201005081454.GA493107@localhost> <20201005173639.GA2311765@magnolia>
 <20201006003216.GB6553@localhost> <20201006025110.GJ49559@magnolia>
 <20201006031834.GA5797@mit.edu> <20201006050306.GA8098@localhost>
 <20201006133533.GC5797@mit.edu> <20201007080304.GB1112@localhost>
 <20201007143211.GA235506@mit.edu> <20201007201424.GB15049@localhost>
Precedence: bulk


--Apple-Mail=_412C097C-2A01-4EE1-8676-2B5C5C1FD48F
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Oct 7, 2020, at 2:14 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> If those aren't the right way to express that, I could potentially
> adapt. I had a similar such conversation on linux-ext4 already (about
> inline data with 128-bit inodes), which led to me choosing to abandon
> 128-byte inodes rather than try to get ext4 to support what I wanted
> with them, because I didn't want to be disruptive to ext4 for a niche
> use case. In the particular case that motivated this thread, what I was
> doing already worked in previous kernels, and it seemed reasonable to
> ask for it to continue to work in new kernels, while preserving the
> newly added checks in the new kernels.

This was discussed in the "Inline data with 128-byte inodes?" thread
back in May.  While Jan was not necessarily in favour of this, I was
actually OK with improving the ext4 code to handle this case better,
since it would (at minimum) clean up ext4 to make a clear separation
of how it is detecting data in the i_block[] array and the system.data
xattr, and I don't think it added any complexity to the code.

I even posted a WIP patch to that effect, but didn't get a response back:
https://marc.info/?l=linux-ext4&m=158863275019187

I *do* think that inline_data is an under-appreciated feature that I
would be happy to see some improvements with.  I don't think that small
files are a niche use case, and if we can clean up the inline_data code
to work with 128-byte inodes I'm not against that, even though I'm not
going to use that combination of features myself.

Cheers, Andreas


--Apple-Mail=_412C097C-2A01-4EE1-8676-2B5C5C1FD48F
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl9+gAkACgkQcqXauRfM
H+AFwg//YZJLR/QqnxWdf/B6mT2xxjTmP/ijQaHafPYl+mE80fRN3czAUu4ob73F
708WjYgxeY3WcID+pPgqtOXU3yp4RhMzv3rzkHaR7T8kHY314l4K7p3/4BSJT/dz
gMZ++W3kfXJy6WbmlnWMlx069epKyiuzjPDtYeq039PaEwM/NpfbJxRx3b5bPjV/
M6CALzuUoIdICzUWD680qt9IfpNABv77LHwuGg61I7NbUlwhDdESD4/j14c4oNkB
KATIXDbZEuc5xN43o8C0gfSEDy+gO8+eJkq8rPiwLjWf7bgI3LnN4EyIolP/l3Bh
PI6KOp9ZQhuw9dyl7OCcNLM0d2EGygK7G0pmpvc1ajuQnGZEZq3wF/US96NVYLgy
8k58JHhpXV6fwxmaQRHjkA954HA5GllsS1gLVTWEFR39dlvpNgiKazqEYfGR8l/9
JAuTZqd/DWX2vxZ3ViC5sAgLcfpmWYBUabWNSsvendZucRgip1g2IgXBu9S7VB2Q
vry8B/BZNzDhIJTk6NeZZg+V1+VbireWalQI0GEiW1OQkDVVKN++bRydtMMutn0v
wYMvXcHcr2Dn5tPfUoh2dkOyS54S5oX8ZiRJxdtdx69AVyfLXFAsBwcxHwKXPof8
WgOubQcTpp/xSLYBqhjJbHfrHLvp/7Se0NtxhqA2Hpv6Qcug2Ms=
=+7Es
-----END PGP SIGNATURE-----

--Apple-Mail=_412C097C-2A01-4EE1-8676-2B5C5C1FD48F--