Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1734566pxu; Thu, 8 Oct 2020 20:52:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBRdnFl4S8CO1WQ625wsrSdjLlL9k3abT/Dbq7Yl3W/g7toMiU6oV2ytJLF+y1ZxDnt48B X-Received: by 2002:a17:906:b1a:: with SMTP id u26mr12056259ejg.23.1602215557175; Thu, 08 Oct 2020 20:52:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602215557; cv=none; d=google.com; s=arc-20160816; b=szKTqjzmd0DI8d62M8aNFlGOntz1g7hZdxdSNz5KqtIVl4bhpIF8Kfw1a7ZotZajeW HiOe3HH7f6BX/xvBFSUpYK3wqp1XhiXwqOroaXzrDtw/3LjlRa/ruykqRT6S8Ju8H4OC MMwYNZYF09/a74Szy87Ey/22QAXTCKVfPhuH8ZORPpalhzRHacei5pMVHdU2PKtopC6j JBVeFLnkxnj5YsmvdmfXMIt6dnPyRtXLyZASmVZVCGqlzQxlnFixQWZT3gXd2VYtbsyN /X5UxXHhTY+14pckzXQ7cjfHZE0QRBuT00MwBq9fRI1bC5eq60zjsuEu45RO+gGUZQUY 6RBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=fzy+aCKLGyRY2hWKCywj440ZWiF83ApRSSPUjU7kRbQ=; b=yc3504anlYnD2Rz6d7Z3ROmDl+ZRadRe9cD8cnqZVicLzPSKJRtgK5vmJscX4oaw3+ RjP3OklopAgeS5kS0ICESkKxdbVwLv0oHaS7QdeRKKfBGhroST3PrMQytrpgR1A3Vy5a O8Y61LeQG3uj1azRr7ZHt9VBUCo4GbZwcqOmcCCXJMq3jytH5wsVUSYs9xPKOde7TyWU dD1Zju8bE88plq4gyFZlpifd9uXhvML5T1KhpZ9Z8PcYxZDTKzqApIpcrsTs5v/tOYzF YHDMjIAoS54bC+DZ33aCjPwV6P1YTQKcFalZnTu0DZlqL+50vaKLYTuO4gC0V2B0GB1U ypJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si5319955edj.87.2020.10.08.20.52.14; Thu, 08 Oct 2020 20:52:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730675AbgJIBtO (ORCPT + 99 others); Thu, 8 Oct 2020 21:49:14 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40333 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726499AbgJIBtO (ORCPT ); Thu, 8 Oct 2020 21:49:14 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0991n0he026828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Oct 2020 21:49:01 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 91EBE420107; Thu, 8 Oct 2020 21:49:00 -0400 (EDT) Date: Thu, 8 Oct 2020 21:49:00 -0400 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.com, adilger.kernel@dilger.ca Subject: Re: [PATCH v2 4/7] ext4: use ext4_buffer_uptodate() in __ext4_get_inode_loc() Message-ID: <20201009014900.GD816148@mit.edu> References: <20200924073337.861472-1-yi.zhang@huawei.com> <20200924073337.861472-5-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924073337.861472-5-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 24, 2020 at 03:33:34PM +0800, zhangyi (F) wrote: > We have already introduced ext4_buffer_uptodate() to re-set the uptodate > bit on buffer which has been failed to write out to disk. Just remove > the redundant codes and switch to use ext4_buffer_uptodate() in > __ext4_get_inode_loc(). > > Signed-off-by: zhangyi (F) Thanks, applied. - Ted