Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1735040pxu; Thu, 8 Oct 2020 20:53:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvxfhF4ALiMFj500r2MVOWaUEnKzNmF7B94RH7zVnzZIQyfB5CBj+Rt3OdwMWicQ/DFikT X-Received: by 2002:a17:906:b1d2:: with SMTP id bv18mr11676610ejb.528.1602215616368; Thu, 08 Oct 2020 20:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602215616; cv=none; d=google.com; s=arc-20160816; b=iILmg0ngbK/2mzPSbjh5VVwIOu3VA/PcCeGvQgoXZUyoyis2SQL8eDJtohcUIu3Gl+ agm3YEj8ICBqxN4dVz/wUo5fAJs5L3NBcLiA+Cx6WUlAqJDk0ixdNYWPdYvRb3ZOVW0I P5W/phFODU+bb0XWGMnJ5xKKzVrnx/A4DpiN+ypjminf52i4RLLvgkt0C2usAuo+CJGr 7R3+rRMrWUNBbhmDg/UcqjmspmHnbbkiVortqHbHYG3AyOlQJUxQbwryF3hEpZ95ZZP8 qxZ+6LIZB6Hz1E3wUyeQ9hpOMgjniZiYykQA+eYLANpx9HK4OVrQDM8TxMKzLhtCC+lG /Ubw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wXdff/xVIN1VMNS8HHYVOJkuoiIc1D9/qjxe9yaMrAo=; b=DQ4rgV0IHXOE4y6YaooLsJJ8AXQfVUMfdV8E2sbibJ3m4e4XRQh83v+PhWck9e40+U AiQA/aKQ9lwh4xXCYqDmbwKwpWUNBIa/cVO8Lgqy4sv3WOzupvmsKO92ZL/Une3fVI+g aivx9XTP2gI5nGvKcLq2Rjzk40SUeqkyv7hbg8VSmOvvAxMTYgemPSw00FFF87mTIfrD n1ebIvCCHXGEDIekGKyo62phrd6QQ9x7Oh2gvlm8JLm24pnpN4Peh/plKRoVaz06GsWw qHl19SnMkttZszL3tSNftY7nmyGJj+wYjDU587AX9r4xJS6zQeeGLMuqJYSL9X6oCyVr YZ4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si5396536ede.8.2020.10.08.20.53.13; Thu, 08 Oct 2020 20:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730767AbgJIB4N (ORCPT + 99 others); Thu, 8 Oct 2020 21:56:13 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41233 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730755AbgJIB4N (ORCPT ); Thu, 8 Oct 2020 21:56:13 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0991td4I028620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Oct 2020 21:55:40 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 43E0D420107; Thu, 8 Oct 2020 21:55:39 -0400 (EDT) Date: Thu, 8 Oct 2020 21:55:39 -0400 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.com, adilger.kernel@dilger.ca Subject: Re: [PATCH v2 5/7] ext4: introduce ext4_sb_breadahead_unmovable() to replace sb_breadahead_unmovable() Message-ID: <20201009015539.GE816148@mit.edu> References: <20200924073337.861472-1-yi.zhang@huawei.com> <20200924073337.861472-6-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924073337.861472-6-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 24, 2020 at 03:33:35PM +0800, zhangyi (F) wrote: > If we readahead inode tables in __ext4_get_inode_loc(), it may bypass > buffer_write_io_error() check, so introduce ext4_sb_breadahead_unmovable() > to handle this special case. > > This patch also replace sb_breadahead_unmovable() in ext4_fill_super() > for the sake of unification. > > Signed-off-by: zhangyi (F) Thanks, applied. - Ted