Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1735058pxu; Thu, 8 Oct 2020 20:53:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyhPiGgvkrzYokF5i3W0kndn7nUNMnrTKrhNrnlVn9fAw3yo0iklvua2U3NMqbUHxAAUjV X-Received: by 2002:aa7:cd90:: with SMTP id x16mr12245613edv.302.1602215617795; Thu, 08 Oct 2020 20:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602215617; cv=none; d=google.com; s=arc-20160816; b=oKaQLbOqYVthbeMvVXgkwopQzDsG6bw+iFrKlH67qds+yvc/0x20oq3mQ901c6I8Yd Z71dJjKEX7+ySV7URs3cGswgQaMDvZzCS1NocveK0rNyCuDjL12RnVrVCOULa6ixoD9f gaurU3fMjnyvW3QzWhr++9HfmR3PsJ6YKoU5z+A05lidbgWpFvBtHYBXuO8HZJCRE+Be DAJ8VVZTNqERNTevNtk3NGCYbFVBU6vf4uOMHXac0zy9+oIc4/OcupULZ/9ManYhgN1g kDZjcQmkP+LcCRJGRJKem1iT3cGRzS+Q06RZytjCDiiysaAITyrtfjco8O4eoOeGJI0X kCqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=MiAsUZohB2dGocsl6etKstAqDk0FyhwQM41KWlZfUvA=; b=LaKSAMIjlEdE5cLXemLURckKPcg8iTETBOpyTbwt4GJ7f8DJ9sLw7RKhbt74dF5dRx dnbDPCCpIzUf+z2QI+RBVqAkyY1IbA/AmUyvY6PIAvSN6qBLj+sKtARMono0FqYWazwH viZ9mdNZVia463dBV5YH+pOGcVE17XABAMrQkfs7nHZ1w9XEEZ+HhvQL1N2AcFXBO9PG 99rrEnEpW2N+k76oouRfGPLnKHv8iIXem9jSemlmWasIf38xFrC6QeyQ64iV/d1rxNuA h0UH+zpWzZ7bfLuc/zmkwD2qCUDDdulKtdLzMMgMgIR7ORijRUZbvBWUmFr5/v9GMKM/ WHaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo19si5426444ejb.252.2020.10.08.20.53.14; Thu, 08 Oct 2020 20:53:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729746AbgJIB5g (ORCPT + 99 others); Thu, 8 Oct 2020 21:57:36 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41451 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729285AbgJIB5f (ORCPT ); Thu, 8 Oct 2020 21:57:35 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0991vJta029091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Oct 2020 21:57:19 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id DC942420107; Thu, 8 Oct 2020 21:57:18 -0400 (EDT) Date: Thu, 8 Oct 2020 21:57:18 -0400 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.com, adilger.kernel@dilger.ca Subject: Re: [PATCH v2 6/7] ext4: use ext4_sb_bread() instead of sb_bread() Message-ID: <20201009015718.GF816148@mit.edu> References: <20200924073337.861472-1-yi.zhang@huawei.com> <20200924073337.861472-7-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924073337.861472-7-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 24, 2020 at 03:33:36PM +0800, zhangyi (F) wrote: > We have already remove open codes that invoke helpers provide by > fs/buffer.c in all places reading metadata buffers. This patch switch to > use ext4_sb_bread() to replace all sb_bread() helpers, which is > ext4_read_bh() helper back end. > > Signed-off-by: zhangyi (F) Thanks, applied. - Ted