Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1736617pxu; Thu, 8 Oct 2020 20:57:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkgH2fetU2xxmq03XwNkgle4h2sDhc3KfVUD2NcjBBBvsUWnTruZIpyHO0HcrgUiL/j60I X-Received: by 2002:a17:906:7f8c:: with SMTP id f12mr12610980ejr.8.1602215821409; Thu, 08 Oct 2020 20:57:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602215821; cv=none; d=google.com; s=arc-20160816; b=XxOwo+OtgCPxT6i8hJnx3U0pDqgQv7CxqPlrwe7MMy5CiVVYIiFc+ENlRd/Yakb5bf 1dIDM5UMZNlKvj+08K4K8yeMLeRWrIOgGyqaVg6kPNKKKOtSRoP3gQrP7rqgOm+5IPY8 Gqj0/dJR396LpbiPAaFUKMhjEXJvpMPp1CHfo7DU/iFyBn5aQkAdCTFk/bxRdxRUSaTy 27hmPdz/unqQH2Ut9hGKqGt2nqZB5/jzhU3R1GRM5zC/GttpAplfdDMwoi44eRrozEha JlDheyKY3kviSRC0OUWVgruvhb09Y5/0bMKzZOp+mjvr2Ztm9R2fINDM9SDaGqvag/Bp 7t4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=hM76A/LcGYdIZzhD7dnbwRmdA2+hhoIZWVC+jQOxMMg=; b=s5ml+BZFwXp6gEsN9eh8Q7+MhU1rQtNhLayMw6Ue2e985MgETmBge2CZMESFjZyeSt VHeVEZrRpwaZj32vT4+46oMh96sR8ZUhi8H2OhFEYe+6igcOH4irtM10il+aocf2rziE NiJPSMxkP+75ok6xvhcUPThiz9E4K9Yx/hmOsvsAERhdifEHu3wOZCuafZZ+YrXNoraW kGZ7ZqHq1PfrV3X94gqjedjn6rGSotxreD1WH8m7oaqnTQjR/e623zR7DK5tB0ysmQ+w ArMR5ZM6JDRWLAEuPrXsR9tSqTFOuqVsJfFKEiVLYIs6u1vnUViXZoAiabJtPv1OodOB +qWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j24si5144651ejb.48.2020.10.08.20.56.37; Thu, 08 Oct 2020 20:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730876AbgJICAk (ORCPT + 99 others); Thu, 8 Oct 2020 22:00:40 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41917 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729285AbgJICAk (ORCPT ); Thu, 8 Oct 2020 22:00:40 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 09920GT4029986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Oct 2020 22:00:16 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id B9297420107; Thu, 8 Oct 2020 22:00:15 -0400 (EDT) Date: Thu, 8 Oct 2020 22:00:15 -0400 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.com, adilger.kernel@dilger.ca Subject: Re: [PATCH v2 7/7] ext4: introduce ext4_sb_bread_unmovable() to replace sb_bread_unmovable() Message-ID: <20201009020015.GG816148@mit.edu> References: <20200924073337.861472-1-yi.zhang@huawei.com> <20200924073337.861472-8-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924073337.861472-8-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 24, 2020 at 03:33:37PM +0800, zhangyi (F) wrote: > Now we only use sb_bread_unmovable() to read superblock and descriptor > block at mount time, so there is no opportunity that we need to clear > buffer verified bit and also handle buffer write_io error bit. But for > the sake of unification, let's introduce ext4_sb_bread_unmovable() to > replace all sb_bread_unmovable(). After this patch, we stop using read > helpers in fs/buffer.c. > > Signed-off-by: zhangyi (F) Thanks, applied. - Ted