Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2610651pxu; Sat, 10 Oct 2020 01:12:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOiuHDJGY/xwyOf7Q8dXFtU+a4TWHQ45ali1aPKDCQhbRm4NO861kFhiiEIs3NVMa6ppbx X-Received: by 2002:a17:906:f0d8:: with SMTP id dk24mr18131020ejb.492.1602317553533; Sat, 10 Oct 2020 01:12:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602317553; cv=none; d=google.com; s=arc-20160816; b=vxvUSTRLC+OYiKeLjSnPaGJVQQBT0I/XvBbhPxBmBOQ1IGF1yedVqztRng6eRCEItv AFqqAfSKeoa7//HGRbXDmVInqIFo0IEHPlwBQ07rm22W6AXryHdlwB4vrEnROO4lQVXE DfXiaklQH4d5HBYTCEraqxawPg3b3dXbHvKMCewUsHibB6ltFAcd7Q61FDk5qH8Jcq37 dGZb9oz+6gt/dUQTTkkKhWQWGY68Zhuii7DbrP757VqJeHPMtI8Qr5DkLV2PnSZTu385 ybHYL1iSMtkQwWotJBSE3rtNrKULi/SrbFrsxBYBwIMCCwn78Girn3FS0C+Td00aucvN w6kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=hKwlK3WolBLUufkeWDHCi6j+X4NXa8gQFiKyGjbOY3s=; b=sE6+SamGiedjF54BDkMACwdhRFFr/aJHiEgI0iewJDxYxvuH3IAJ7LNKi6rXAw95sH /4qe5eeskuqhbWsuOKz0qth0ZJ+SAwcmVMtEKnvVfYlJPaTFlLDGEv6fL49zXOMpwjKK i6Iua16oyDuWcThDBUWeVvS7FFJufZuJ+1XSEGWI5kT/wN4NZrJ19go8gOoR9HbLndP0 htU6jFuO+Nass0guIWKvUvLoLZElD6eQrCbTkhBPzqZQ9V6297Oab/X1Ac+IXJojP2qb q6HoV4wpUCCBGV8ao6jHK1VWi14Sm1XZVMaxcPKTSIuAMpzaO+RqImCM4DyetK27ot+D eBvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=edx7xet+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si5961148edi.24.2020.10.10.01.12.05; Sat, 10 Oct 2020 01:12:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=edx7xet+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730732AbgJJDP2 (ORCPT + 99 others); Fri, 9 Oct 2020 23:15:28 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:11466 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730256AbgJJCyU (ORCPT ); Fri, 9 Oct 2020 22:54:20 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 09 Oct 2020 19:51:17 -0700 Received: from [10.2.51.144] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 10 Oct 2020 02:53:07 +0000 Subject: Re: [PATCH RFC PKS/PMEM 57/58] nvdimm/pmem: Stray access protection for pmem->virt_addr To: , Andrew Morton , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Andy Lutomirski , Peter Zijlstra CC: , Dave Hansen , Dan Williams , Fenghua Yu , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20201009195033.3208459-1-ira.weiny@intel.com> <20201009195033.3208459-58-ira.weiny@intel.com> From: John Hubbard Message-ID: Date: Fri, 9 Oct 2020 19:53:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201009195033.3208459-58-ira.weiny@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602298277; bh=hKwlK3WolBLUufkeWDHCi6j+X4NXa8gQFiKyGjbOY3s=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=edx7xet+HWktPTMH7LfazMaeZj84i5/Le7BE3m/9xNKYA9bmh246jZEvn48F/uMcW RRn8BggXdwK6EgYw84fvX6LW3WH/wQjijcVtcfekd8K6KkJdzgyiWWhhWRHsAgsUWu ErO3rgTi0L/NWozRhmjxim3aejVQ7k0j+Xmczu6ahvjgHQEdG1f6IxukspiHHh4eDZ vXW13vRjbU9kKvq3xSMRRweChxuwg1Gt9UWgcBiwICYzh7lbhEKe0zR7+e8y/8iSgu 9o2Hr0ioZGbS1OLU7+SDtKlkAPg/fZiUxFefl5DnOwU2H5+VRhK6GCiKvAXlVbpTMd H8SS1utYxNiTQ== Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 10/9/20 12:50 PM, ira.weiny@intel.com wrote: > From: Ira Weiny > > The pmem driver uses a cached virtual address to access its memory > directly. Because the nvdimm driver is well aware of the special > protections it has mapped memory with, we call dev_access_[en|dis]able() > around the direct pmem->virt_addr (pmem_addr) usage instead of the > unnecessary overhead of trying to get a page to kmap. > > Signed-off-by: Ira Weiny > --- > drivers/nvdimm/pmem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index fab29b514372..e4dc1ae990fc 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -148,7 +148,9 @@ static blk_status_t pmem_do_read(struct pmem_device *pmem, > if (unlikely(is_bad_pmem(&pmem->bb, sector, len))) > return BLK_STS_IOERR; > > + dev_access_enable(false); > rc = read_pmem(page, page_off, pmem_addr, len); > + dev_access_disable(false); Hi Ira! The APIs should be tweaked to use a symbol (GLOBAL, PER_THREAD), instead of true/false. Try reading the above and you'll see that it sounds like it's doing the opposite of what it is ("enable_this(false)" sounds like a clumsy API design to *disable*, right?). And there is no hint about the scope. And it *could* be so much more readable like this: dev_access_enable(DEV_ACCESS_THIS_THREAD); thanks, -- John Hubbard NVIDIA