Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <43B157BB-33E4-4D82-8A09-0E1BCACC55D9@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_6AF3D071-5BD3-4E1B-9E87-F5519B690E5E";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation
Date:   Wed, 14 Oct 2020 18:56:13 -0600
In-Reply-To: <20201013133848.23287-1-jack@suse.cz>
Cc:     Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
To:     Jan Kara <jack@suse.cz>
References: <20201013133848.23287-1-jack@suse.cz>
Precedence: bulk


--Apple-Mail=_6AF3D071-5BD3-4E1B-9E87-F5519B690E5E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@suse.cz> wrote:
>=20
> Explain which valid block sizes mke2fs supports in more detail.
>=20
> Signed-off-by: Jan Kara <jack@suse.cz>

Should this mention that the default block size is 4096 bytes for most
filesystems?

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
is definitely an improvement already.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/mke2fs.8.in | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>=20
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index e6bfc6d6fd2d..0814d216f3a4 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -207,10 +207,11 @@ manual page for more details.
> .SH OPTIONS
> .TP
> .BI \-b " block-size"
> -Specify the size of blocks in bytes.  Valid block-size values are =
1024,
> -2048 and 4096 bytes per block.  If omitted,
> -block-size is heuristically determined by the filesystem size and
> -the expected usage of the filesystem (see the
> +Specify the size of blocks in bytes.  Valid block-size values are =
powers of two
> +from 1024 up to 65536 (however note that the kernel is able to mount =
only
> +filesystems with block-size smaller or equal to the system page size =
- 4k on
> +x86 systems). If omitted, block-size is heuristically determined by =
the
> +filesystem size and the expected usage of the filesystem (see the
> .B \-T
> option).  If
> .I block-size
> --
> 2.16.4
>=20


Cheers, Andreas


--Apple-Mail=_6AF3D071-5BD3-4E1B-9E87-F5519B690E5E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl+Hni0ACgkQcqXauRfM
H+D1VA/8CAy7rQzl+ikN1HdfYSuvo10e6VI/eWsxWIwD3azwcuOjvRyxMJaBke2A
G8myaSG0Q+ZxBN7X0hmfI7REJZL7kEe9s81iz+3abNJzgmK7E/UU9MAo2rQGH4K4
h/8TCJk/RR7LMIh8Qcv2mIX60tJ4c2LOgT/h1Br70ZITD3GezmEn5GptU88bO07k
axRsL54P3t9Q5i3t7dOWHf5nj+Ahb4UyXMe8yvuJ5rfZxoGBOefrDLIsBDSqRN+h
Obk5F0xvAFoq0hJQ5hjPvg8zP19tuU8rLKB3kOtswVuhCHKiwCrDnS1IT5opHbqt
UikiOu0ixFEwB6SXgOWvwgyhq76UYHvVLEqfbMYITYq0LY4c/4yS6FigCqcegzVA
Nc0mbeSI7Nm0vs6+hYSqkIKYhOCpYQYLP/y5XyAQ/8vYiR3uJK0So+RxLqf6g8F5
NMmg1DDPtfrJXlR+P3Yvtv9NO9xGc/2/gp2Ks2/vI+bQ9eAtP7YB6RHPi02pXYX6
dUdz2oJK40yupBKdfqq1at0+1Q21ENFDYjXo4zICg82R1NXTtl7nLsXvzqfSrYy6
BSSBwO2zUtpwT25lgT5EYnmmWw1e6csX4u5a4KmLknjGZnAelzEVpUOFelmE1p+W
16prlTKakHLh4GoRXP4kr+EpAAwDouXn2Ggf4LJqp64dR1aWFGc=
=pTAf
-----END PGP SIGNATURE-----

--Apple-Mail=_6AF3D071-5BD3-4E1B-9E87-F5519B690E5E--