Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3878769pxu; Tue, 20 Oct 2020 02:58:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydAeV4lpaAjGtj3fW7LzbzjSjWOXfkQxaR5YvCb1mByZ+CiuS8DEJ6e3SafgXP0ex+UWHh X-Received: by 2002:a17:906:2e8b:: with SMTP id o11mr2412467eji.128.1603187890033; Tue, 20 Oct 2020 02:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603187890; cv=none; d=google.com; s=arc-20160816; b=VpCpt1g6x2A1coZ8+Y0VyirLzEa7fT5GPmc0wplw+mmWq5Ei9r6R6+O+lQwKhQigXC n71/Og7kjRkVJInuTY+KFx5aHnzzWcOt9Rs+qhX8M8Jmca4cB797cARR77NXQ35xfAiR PznNPq1muBCNHJ3dfeZDaN/dAzNEV5T1v9KD8C7asE0s3DWyjlWzeP3aicP+bFTlzYeY zjhJN3UjYvlLfwfZquFayLPTjMB/q6q1z+9ie5hiNmaOM2tGG6kGqQHeMSB0mZxgz43P i+2nOIYmzHZJ8cnFyhU6NUXIrfKNxxZqWouR5h3xpv9fXaj9y47ySFe1SNnHGj/IcJX8 g22g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=a8S48pmW0MdXGeMpRIUDaJEIt2E3yJvJ61VVapByoJU=; b=mfWGj+0JwvOFl0J4uqcIyQdzCk7CRiBO+R/XAdTUZ+DBljMNirqkcQlcAqANRsvCYL i51siNm9CBU4WfmZhPb0olo8XJ1ZcDYPhLSZ/yw/fK3kGqemegEyD3F7c5w5rw46flU+ mboEjaMdiGWiGpAoJuo1vENFkja5mPjnjVAIKOh0d3ijbDhmlEUoTggOq5uITYaLKyVf ZUYdR7VBTRkCszNma5E673QCDn19HFnv2GTFX4oeAgafxUn+xkar8s7u9/vLSGkgvh2x FiVCSEo9CufOq/1A+MDGoQC7EgiygccRn2h0IcmSYU6LoFN/vAGxAJVbGElJNt0MkKhA Yj0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si986733ejx.177.2020.10.20.02.57.39; Tue, 20 Oct 2020 02:58:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728742AbgJTHhp (ORCPT + 99 others); Tue, 20 Oct 2020 03:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbgJTHhp (ORCPT ); Tue, 20 Oct 2020 03:37:45 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE2D9C061755 for ; Tue, 20 Oct 2020 00:37:44 -0700 (PDT) Received: from ramsan ([84.195.186.194]) by andre.telenet-ops.be with bizsmtp id i7di230024C55Sk017died; Tue, 20 Oct 2020 09:37:42 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1kUmDF-0004Tm-U5; Tue, 20 Oct 2020 09:37:41 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1kUmDF-0007aB-Rh; Tue, 20 Oct 2020 09:37:41 +0200 From: Geert Uytterhoeven To: Theodore Ts'o , Andreas Dilger , Shuah Khan , Iurii Zaikin , Brendan Higgins Cc: Paolo Abeni , Matthieu Baerts , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it Date: Tue, 20 Oct 2020 09:37:40 +0200 Message-Id: <20201020073740.29081-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on EXT4_FS instead. Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") Signed-off-by: Geert Uytterhoeven --- See also "[PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it". https://lore.kernel.org/lkml/20201019113240.11516-1-geert@linux-m68k.org/ --- fs/ext4/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig index 619dd35ddd48a973..86699c8cab281cbc 100644 --- a/fs/ext4/Kconfig +++ b/fs/ext4/Kconfig @@ -103,8 +103,7 @@ config EXT4_DEBUG config EXT4_KUNIT_TESTS tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS - select EXT4_FS - depends on KUNIT + depends on EXT4_FS && KUNIT default KUNIT_ALL_TESTS help This builds the ext4 KUnit tests. -- 2.17.1