Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp609510pxx;
        Mon, 26 Oct 2020 16:47:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzPeKnuOLtF6Cx7Oh5fb3KfhxghRRw1eqwNXmXoW9qD/ndcj5fqA7tUtgfYHxlSnF742la9
X-Received: by 2002:a17:906:e10e:: with SMTP id gj14mr19023768ejb.134.1603756026866;
        Mon, 26 Oct 2020 16:47:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603756026; cv=none;
        d=google.com; s=arc-20160816;
        b=shVP1CTzx34J8JvPACELOWqSYBwlwRRwiagogZAKdEPwxpllP9cWXF2Cgjd554z9hw
         YXoNKbND/aCpPT9f7gZFeZMr7833GeyMYolJNJQ/xWOW84YuDjnyq+4/IANWbnh9Y1O3
         2RX21utdOgi7UJPQNnsj23ZWhyKy6DEkunVJf4Xu40Y/faPCSYObz4V7FyU2zK7EFstk
         /k5kneSQd6zSc6eIPdMavzWfEYFXAwkUjWpOAWGqgYBCQSOSIW5rrfD4rPzX703gGsVY
         02wuW4BurVP2ktezM/ZmS2p7wGT0yZh7phOIPEcmFBqSeLCKaehtC2VkLxQPMvndhj5+
         WM2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=wXbdbicKVeXDRSO9MY7B1zqIT3oHv+LTHNtkKPt2D2A=;
        b=DwzCFg2cbYhyeUKsS3r7hw6TGzujWlOnfUm97w46Va/3tKs6IJ/RdQwFGikzHzq0oU
         UYYVypG5ceqZLZMgnVxg0CludbJSjjK4sVUdrB9KUJfC9gJNQa5EWPz8w8fvOmTnUqq6
         6z91g926oSta/mcy115wbIH8I2J6F0uNPSrK37UZAeVSJJ5BnQXx3i9SbYC4QODYt4s6
         xhkYr1g9E2BXBxK4dA7AP8tk0B/pPtLo6+jj/zI3E+Pg0q86oczNhk56n3dUNcwJSTIk
         16pk6AIhjAWKiTa87PBr3BVKVN8MPPRGA7zzxObpJTQo2pPsKc32yZqGOLDWgXH+Fx5U
         CHOQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b=c1etfYcK;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Return-Path: <linux-ext4-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p3si8118875edd.200.2020.10.26.16.46.35;
        Mon, 26 Oct 2020 16:47:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b=c1etfYcK;
       spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1789241AbgJZSLl (ORCPT <rfc822;qiaokang1213@gmail.com>
        + 99 others); Mon, 26 Oct 2020 14:11:41 -0400
Received: from mail-qv1-f68.google.com ([209.85.219.68]:33270 "EHLO
        mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1783565AbgJZSLk (ORCPT
        <rfc822;linux-ext4@vger.kernel.org>); Mon, 26 Oct 2020 14:11:40 -0400
Received: by mail-qv1-f68.google.com with SMTP id w9so4762338qvj.0
        for <linux-ext4@vger.kernel.org>; Mon, 26 Oct 2020 11:11:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=wXbdbicKVeXDRSO9MY7B1zqIT3oHv+LTHNtkKPt2D2A=;
        b=c1etfYcK4UNhq0LLeOS3Fyh2e89joQELvnJVPIbaj1PWxbTphDsP0AjrZNeoBzlS5Q
         9Vc9V4DtO54YtziHvzgJd/VUGo2LkbvXnN6FWCpvWZCwCL41WH4/MztPmFEl1teTQxqw
         C4yKXYKJY5GpMxboXZzlnSt/9rCemQusXpalfDg7cf8AGFxMol3mWQgoqmtBi0TLleM8
         ge7o+r2S7KDzHYYojoADRVsvln7pDRE2hoW9STGUerFkkVbV7OB4CAO49jRvQU7eCi7c
         CRQVJmVZHnsTkA3QvN2MiHs2yvLPrafKpvtrKpRUZSx0/q56gFdFIsEuXibDEFD4svFx
         fkvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=wXbdbicKVeXDRSO9MY7B1zqIT3oHv+LTHNtkKPt2D2A=;
        b=VcNJnYWfdqcOfDr7nEecMipU1V+f85GwZ1kr3faRbjWedH9ebZtGFKEynwxuwjDyTC
         jelbgVJX7vfWNXm2HpR1IzA8nxoECb0eENTNqUqL/RW9i2J+7s3mI2VaPZ8a7dUd3ijp
         M5EzV34yH2MfamAL95L/vnHB+BJM5GtecU3vhGMl/zSid6TPHnWoJ6VakhlQUdFE/D+N
         yv3ZDho973GzHSfwFnM3O6rWWu7kCQFtXR3jJGsxVFoWYqfo6XUnZqWdywIKRLscUzb5
         7QVBPusekNe6rubkneZ10GfQBFyUKrup5kPuvQJ2aulSicSi3vMxihl37ct/diACCraF
         HjnA==
X-Gm-Message-State: AOAM532yd6ByYsm2VhO2kGnFMIRHyUjTrmJx+82bJEzBGCgtMTD7BPnW
        cauuKXSchrRnuoS2kxyyTPeAbGs40UJpJ9W6Hl8X
X-Received: by 2002:ad4:46a8:: with SMTP id br8mr18327630qvb.24.1603735899186;
 Mon, 26 Oct 2020 11:11:39 -0700 (PDT)
MIME-Version: 1.0
References: <20201023150536.282568-1-98.arpi@gmail.com> <20201023150634.282631-1-98.arpi@gmail.com>
In-Reply-To: <20201023150634.282631-1-98.arpi@gmail.com>
From:   Iurii Zaikin <yzaikin@google.com>
Date:   Mon, 26 Oct 2020 11:11:02 -0700
Message-ID: <CAAXuY3q6c3d5kkLOqsG2LBmBYS4d9qRuEeZ2ChpJF1OVTkV5gw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit
 parameterized testing feature
To:     Arpitha Raghunandan <98.arpi@gmail.com>
Cc:     Brendan Higgins <brendanhiggins@google.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Marco Elver <elver@google.com>,
        "Theodore Ts'o" <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

> +static struct timestamp_expectation test_data[] = {
Can you mark this and the rest of the hardcoded values as the const they are?