Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp610428pxx; Mon, 26 Oct 2020 16:49:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7M5zEyqKrids7TFiNrDlkf/9umRns77vvDRDs9uwfvlxeRsUqO1k9nI/++1huxxbTNRPD X-Received: by 2002:a17:906:590d:: with SMTP id h13mr17667881ejq.226.1603756148420; Mon, 26 Oct 2020 16:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603756148; cv=none; d=google.com; s=arc-20160816; b=hzmk3Ga93FFBfsRasyGfYNXZg7QOMjGhpSc3kzGHYsEB5RU+2thk5zinEAnQWTfWiM IPsy91+B/Rw4zmSNYMadYqlfm+pgsQYiVqupr+D8BMbBuH0ZIbpwhmWAzVtn5bdLL1yd Ulf0CRMaAns5nRs9PqqhesWevHhPLlPY2CHrE3rUzTTa+Q5u1+3lwnM8Q48f8fFR57Tq fRI4fEzRI7brkcs3jd7CFLdKLKO9JkEG961ofp8bbfgV/N3QGqCNYav84MSzzUg6Yk+t 5sPNOXv/jGd1UBb2Yjh0/kqtX9dM1QMxigziSqs1qcHjextdMzH1kbJXhFF1qwShjGKG OBAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=0DNJ0t/C1pzRa+JekKOelQmdqY3jAoAvJFAIIwjzcxI=; b=Y0ZqFDZKihhTJSwLs/H+ia8o7IQL0OkhJKXPOaWV/ENbCU4/18C9eG/BAwFg6yEV82 k//sxe3rKJ1p97O1EIQEzLQjuh9F1tvpyEpX95Cs9ceR7SeHkHZIMbLjg/qYqwXkFjzZ uqlGQtGL+XzpfyQ4ZtmAdSRgQF0lRPpSf9N4Us1ND1CaPWPfmmfdDDrsYhPyLHJIw8S4 W1eO39R3X85YgyndreR+hhvti9IUbzrjnu3xJxJrz9ZfgD5zmCFtrGf/KMMPNmZpdizE X5G9w+sMrhuP3qC/717/a2/i1FvUVWhJ+i8LLZlrNWStIuTVLqVs0FUDFiMQz3SiwijA SwbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c6YDidei; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si8118875edd.200.2020.10.26.16.48.45; Mon, 26 Oct 2020 16:49:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c6YDidei; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783970AbgJZSTT (ORCPT + 99 others); Mon, 26 Oct 2020 14:19:19 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45454 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783966AbgJZSTT (ORCPT ); Mon, 26 Oct 2020 14:19:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id 19so6503325pge.12; Mon, 26 Oct 2020 11:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0DNJ0t/C1pzRa+JekKOelQmdqY3jAoAvJFAIIwjzcxI=; b=c6YDideimVC9ltOEOo02MEpJTj4DfpF8esGdeorn6b8AKxkF2pvnqUpE2QT2H0erxX JoRwY66KYwZpVjGGuFaiKtUdcK1R875E38C++N6APPb6fh37p/ISu9OpW3OFJs3l55Gc 2BSdnrzHCzSj6cBpdG3Nnhs/EFC+eu7Rh5cO0hesmHY6IW/xm5CVqaWmiCegmyrdUFcf Fsm8Nn6CPL3CZwXwunfBaZPVDe9wuDPlMlYK7mI6LsBq+xxaGzUS0VExrUKeLPbFOQWm 6hNrp5T6GQ3lz0sXYDGDXjxHAr74WIyJhsmVJmkvE9KXA6Lf3VQQOuSzoI+Sr1B7Khjr 3CAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0DNJ0t/C1pzRa+JekKOelQmdqY3jAoAvJFAIIwjzcxI=; b=U0KU0N4M/cAQqhVLU6ypO5Y5AnsOLMUDuF2NBMW0TmK4Y7sW08avof+KsGeyQjTo0+ bmaIBiEgcmmyLRTCwvOAC1sEEERXMsUlVSdQcWqYRcKQ1iZwNk0PbUxKlI9g7EXK99J+ Ufbwva+xNUvO2sSFk8BmTOMFUxQw+2BBvdgT1zB5ttn+625xEGpZNynjENLEYyiB9Qyk v7nbJxTwR4hddekGLEYy4GO//yNr9CMjV1dmoxDJDgLSGdgJuPe4TN/aO0Y2uHJ23ePT JqCSUvWUreWu2EG7MfxC9+KenMef/keEI/gOH+3FESKztJpunuxV4nEBhhZ5JobroAd1 AKPA== X-Gm-Message-State: AOAM531iGl4MiDE5sqqIh8jGuNlBXlrSyFkpyY7HBXBjK5arNSCB+/kz KyQwmlpf1ZEIL3MzPIBkrWO1bGJFhgxj5LP6 X-Received: by 2002:a63:4c55:: with SMTP id m21mr18174458pgl.305.1603736357935; Mon, 26 Oct 2020 11:19:17 -0700 (PDT) Received: from [192.168.86.81] ([106.51.240.100]) by smtp.gmail.com with ESMTPSA id q13sm12604702pfg.3.2020.10.26.11.19.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 11:19:16 -0700 (PDT) Subject: Re: [PATCH v2 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature To: Iurii Zaikin Cc: Brendan Higgins , Shuah Khan , Marco Elver , Theodore Ts'o , Andreas Dilger , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Ext4 Developers List References: <20201023150536.282568-1-98.arpi@gmail.com> <20201023150634.282631-1-98.arpi@gmail.com> From: Arpitha Raghunandan <98.arpi@gmail.com> Message-ID: Date: Mon, 26 Oct 2020 23:49:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 26/10/20 11:41 pm, Iurii Zaikin wrote: >> +static struct timestamp_expectation test_data[] = { > Can you mark this and the rest of the hardcoded values as the const they are? > Sure, I will make this change for the next version.