Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <94DB7654-D529-499C-80F9-7ABF25FC3939@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_AA550751-EE28-4E87-97DF-C7B839C1DA6A";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] mke2fs: Escape double quotes when parsing mke2fs.conf
Date:   Mon, 2 Nov 2020 14:37:38 -0700
In-Reply-To: <20201102142631.87627-1-lczerner@redhat.com>
Cc:     linux-ext4@vger.kernel.org
To:     Lukas Czerner <lczerner@redhat.com>
References: <20201102142631.87627-1-lczerner@redhat.com>
Precedence: bulk


--Apple-Mail=_AA550751-EE28-4E87-97DF-C7B839C1DA6A
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Nov 2, 2020, at 7:26 AM, Lukas Czerner <lczerner@redhat.com> wrote:
> 
> Currently, when constructing the <default> configuration pseudo-file using
> the profile-to-c.awk script we will just pass the double quotes as they
> appear in the mke2fs.conf.
> 
> This is problematic, because the resulting default_profile.c will either
> fail to compile because of syntax error, or leave the resulting
> configuration invalid.
> 
> It can be reproduced by adding the following line somewhere into
> mke2fs.conf configuration and forcing mke2fs to use the <default>
> configuration by specifying nonexistent mke2fs.conf
> 
> MKE2FS_CONFIG="nonexistent" ./misc/mke2fs -T ext4 /dev/device
> 
> default_mntopts = "acl,user_xattr"
> ^ this will fail to compile
> 
> default_mntopts = ""
> ^ this will result in invalid config file
> 
> Syntax error in mke2fs config file (<default>, line #4)
>       Unknown code prof 17
> 
> Fix it by escaping the double quotes with a backslash in
> profile-to-c.awk script.

What about using single quotes for this?  That avoids the need to escape
the double quotes, and avoids significant issues (IMHO) when the number
of escapes grows over time as they are swallowed by various levels of
processing.

Cheers, Andreas

> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> misc/profile-to-c.awk | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/misc/profile-to-c.awk b/misc/profile-to-c.awk
> index f964efd6..814f7236 100644
> --- a/misc/profile-to-c.awk
> +++ b/misc/profile-to-c.awk
> @@ -4,6 +4,7 @@ BEGIN {
> }
> 
> {
> +  gsub("\"","\\\"",$0);
>   printf("  \"%s\\n\"\n", $0);
> }
> 
> --
> 2.26.2
> 


Cheers, Andreas


--Apple-Mail=_AA550751-EE28-4E87-97DF-C7B839C1DA6A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl+gfCIACgkQcqXauRfM
H+DN+w/8DjqwNX/YeLXhZC+bqQtWBQ+m+s0EOReQiA/ph0kw0/QAc6CeabyDhoJd
tYxeK8pzopX1Vt4xrzhd4Q9moNe3VZZqQWxofOeNYxIuTc44fxv18RBX+7mVrLH1
/4rhHpZZqz7Ls2KOO2ycKz/+RWIJu9AEjPZzk/SdxB0oKUSnYpAfMrVitzneK3zU
9K1UvHmQNce20rT2y5p42K4i7rqOMdBh0WcVhxhU4MGtEJvD0eGkfiauzYLCBJxU
7Wg0luYmg1wHxGEDRe3/966rXWQ3txf9Z0Zc1hxOlNDE554JKxd2O2F/Tp7WLPEu
fxRaLQ9wl+NgLzybBqXSBC7jfX378V8xOhU6AkxxIHZ8zY0d4H8HmBVB7B5G891W
GY3yed4VK5tEVJsjf5FTUox/zp0wGxlmHDtIy4YvxjlKh6KZ4BLkUHuOxl8lWILK
H7Zl+rnQgCJmzx2Of5wl/8ClxMJulNULI73Zfn/YcL7MDOVa/mZGTnEdRmEXCO1y
X2EqyHzr90kAxcctSgRSIp0LTolz2epHCPo46tjEygfWRH2jWSGufXgKApVaOAUl
1/VAmBkQKpIUdoQYiFmWt+FcDZOFtO9vqZ73pLyzA+0vslPs5U39Am+APqG7M0de
1ICA81ki7JWLobWhmncaIiE0KbrotIkKQLZDjARH2F1PBbvKKeg=
=S+dN
-----END PGP SIGNATURE-----

--Apple-Mail=_AA550751-EE28-4E87-97DF-C7B839C1DA6A--