Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <8B6EE337-4C54-42C3-BB2C-5D191143FAC7@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_CA2CDAAD-51D4-4466-BDA9-6C6EE1AA654A";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: unlock xattr_sem properly in
 ext4_inline_data_truncate()
Date:   Mon, 2 Nov 2020 20:15:36 -0700
In-Reply-To: <1604370542-124630-1-git-send-email-joseph.qi@linux.alibaba.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        Jan Kara <jack@suse.cz>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Tao Ma <boyu.mt@taobao.com>
To:     Joseph Qi <joseph.qi@linux.alibaba.com>
References: <1604370542-124630-1-git-send-email-joseph.qi@linux.alibaba.com>
Precedence: bulk


--Apple-Mail=_CA2CDAAD-51D4-4466-BDA9-6C6EE1AA654A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Nov 2, 2020, at 7:29 PM, Joseph Qi <joseph.qi@linux.alibaba.com> =
wrote:
>=20
> It takes xattr_sem to check inline data again but without unlock it
> in case not have. So unlock it before return.
>=20
> Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data =
correctly")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Tao Ma <boyu.mt@taobao.com>
> Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/inline.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index caa5147..b41512d 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -1880,6 +1880,7 @@ int ext4_inline_data_truncate(struct inode =
*inode, int *has_inline)
>=20
> 	ext4_write_lock_xattr(inode, &no_expand);
> 	if (!ext4_has_inline_data(inode)) {
> +		ext4_write_unlock_xattr(inode, &no_expand);
> 		*has_inline =3D 0;
> 		ext4_journal_stop(handle);
> 		return 0;
> --
> 1.8.3.1
>=20


Cheers, Andreas


--Apple-Mail=_CA2CDAAD-51D4-4466-BDA9-6C6EE1AA654A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl+gy1kACgkQcqXauRfM
H+Du3RAAgkAdP8Gtj/41YaMujmuds3D29TAWjOd9D3+lspZaxG4JXjqyGYBiG1Fm
hvkuySDgSrhBx31at2cHtL3t3RBXekiKNqXDe2ncBjd7i4HV8nMVnW0dqDhu5m8J
V2HYI+jiuL2cjTVDp8wuGGNtS0iIIouCn1NeQywHJREOh5sq5/pwBwQ5CLUJ25Ob
IzYTzB1/xhlYnEaKKj+EPad/JLlzPq6hEkPfcpsg0QiP9BHpy89CEC+qObhvRT2u
S7rVoh1W2gO9VAsWVjsm52DOfbl299xtg6ZmihX0jr0zGUSOdkmjRoOG2O0yqPs4
cZpTH0+NETldm484tvwqc0EhrdFPlWIp5iqq3xaIPW95VnAscUgJAl35tPtI6jAj
fBgSmChwibWVldE/Ve99GEdQ6G60rmbHqoBusj3Ak/+U353MFYnvu7snJjluEerE
Tg6NBFC5ZGQWObqG3hTqaarhQR82y5c0f8+hndA4jKsqlLvkzN0rWN95RUMljr5F
fHNPzqIC+UPXty83iGghDxHXNPww6TTNsLi3C5y3+zcIC8kk5OeIMjZrRE+Vau2C
l9b4QjptS8KsyDWad2JSmnIzU+g5fQzYM+BJmKEabXTahYml8eJNwM7MT06r0FYV
uFANH8Gca8GZmssWmBNn/a4mQrCic4/tNx1kf1tucOXJC4ShbAY=
=j5d0
-----END PGP SIGNATURE-----

--Apple-Mail=_CA2CDAAD-51D4-4466-BDA9-6C6EE1AA654A--