Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 6 Nov 2020 22:52:13 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     xiakaixu1987@gmail.com
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
        Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] ext4: report error message when setting usrjquota or
 grpjquota options failed
Message-ID: <20201107035213.GC2499342@mit.edu>
References: <1603986396-28917-1-git-send-email-kaixuxia@tencent.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1603986396-28917-1-git-send-email-kaixuxia@tencent.com>
Precedence: bulk

On Thu, Oct 29, 2020 at 11:46:36PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> The macro MOPT_Q is used to indicates the mount option is quota stuff and
> would be the same as MOPT_NOSUPPORT when CONFIG_QUOTA is disabled. We want
> to report NOSUPPORT error message when setting usrjquota or grpjquota
> options with the CONFIG_QUOTA is disabled, but now it report nothing. So
> fix it by adding the MOPT_STRING flag.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Thanks, applied with an improved commit description:

    The macro MOPT_Q is used to indicates the mount option is related
    to quota stuff and is defined to be MOPT_NOSUPPORT when
    CONFIG_QUOTA is disabled.  Normally the quota options are handled
    explicitly, so it didn't matter that the MOPT_STRING flag was
    missing, even though the usrjquota and grpjquota mount options
    take a string argument.  It's important that's present in the
    !CONFIG_QUOTA case, since without MOPT_STRING, the mount option
    matcher will match usrjquota= followed by an integer, and will
    otherwise skip the table entry, and so "mount option not
    supported" error message is never reported.

					- Ted