Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 14:03:53 +0800
From:   Murphy Zhou <jencce.kernel@gmail.com>
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu,
        Harshad Shirwadkar <harshads@google.com>,
        Murphy Zhou <jencce.kernel@gmail.com>
Subject: Re: [PATCH] ext4: handle dax mount option collision
Message-ID: <20201112060353.db4ky4ulug3eegst@xzhoux.usersys.redhat.com>
References: <20201111183209.447175-1-harshads@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201111183209.447175-1-harshads@google.com>
Precedence: bulk

On Wed, Nov 11, 2020 at 10:32:09AM -0800, Harshad Shirwadkar wrote:
> Mount options dax=inode and dax=never collided with fast_commit and
> journal checksum. Redefine the mount flags to remove the collision.

Tested OK.

Thanks for the quick fix.
> 
> Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
> Fixes: 9cb20f94afcd2 ("fs/ext4: Make DAX mount option a tri-state")
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> ---
>  fs/ext4/ext4.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 1b399cafb15a..bf9429484462 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1231,13 +1231,13 @@ struct ext4_inode_info {
>  						      blocks */
>  #define EXT4_MOUNT2_HURD_COMPAT		0x00000004 /* Support HURD-castrated
>  						      file systems */
> -#define EXT4_MOUNT2_DAX_NEVER		0x00000008 /* Do not allow Direct Access */
> -#define EXT4_MOUNT2_DAX_INODE		0x00000010 /* For printing options only */
> -
>  #define EXT4_MOUNT2_EXPLICIT_JOURNAL_CHECKSUM	0x00000008 /* User explicitly
>  						specified journal checksum */
>  
>  #define EXT4_MOUNT2_JOURNAL_FAST_COMMIT	0x00000010 /* Journal fast commit */
> +#define EXT4_MOUNT2_DAX_NEVER		0x00000020 /* Do not allow Direct Access */
> +#define EXT4_MOUNT2_DAX_INODE		0x00000040 /* For printing options only */
> +
>  
>  #define clear_opt(sb, opt)		EXT4_SB(sb)->s_mount_opt &= \
>  						~EXT4_MOUNT_##opt
> -- 
> 2.29.2.222.g5d2a92d10f8-goog
> 

-- 
Murphy