Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4104253pxb; Tue, 17 Nov 2020 11:21:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6PUJiK63ESeoTTyADDagvnrkGjQRhz03PVAxhMDRvtRip9z5dJyKpwE3VPRRf/HC51p4W X-Received: by 2002:a17:906:4e56:: with SMTP id g22mr21270905ejw.49.1605640882339; Tue, 17 Nov 2020 11:21:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605640882; cv=none; d=google.com; s=arc-20160816; b=bLTT/35GtMc19LkMxGMj4XhmJU9wmKKSnvZAEMSx+ctL6H3vervcgkATM9oVrkBd7Q 8fo0NesAgKF6n+dbWUg4P+63kb+O/WFEMvqaFCYyj/KUepVYZaDTek/nvLEECCcYHpQj hUBTbw3yyjejmCSMZCwkrbE9FKGyAJeHMltpOtB5fla1fYC9s+wcoQLcQMwFgpgEvd8j lxoe47fvhzl2b4LrTkEWtWx8SAsvdek1OeKrBRkc+qs2koJ8v7qxla8kdR5YxRGFzXF3 UCkLfqHU0QTzY5zoiFgq/uAC+DHvu/pw4Zk7QS6LT8jShAwrSjALzpK6dHHYi6vaMF0y 5Yig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1RRUNI3t3CITKZODZIMFmuNWVf/YCo/kt0uOYK9Zy7I=; b=CL+rJ3i8J/6XIIMY4+IYHB40wxZVAacKYJ/WZITToqHDv5tgUGMdg2MazyUzO1BGWX P/s2CX2EN4zAe9CJOMsWqA5TEVRz6Bsct46peiQJcdreRWiL1n772f91j5U30C4r09oh TQFYcr1xlGzSYHDnL1Mw7iKFYNh2j8ztW7ixMI4cgJaIG9CFEP1p+MfuoRzUrwSsOVRC qyHshGsVdaajeWgMONE9nEVRlKS9gqgqaofICEhhiK75BFjexlq+4VxQ42Y8XXNRKrHZ tsr1rjQl69Grwb3NawxpdRXEz/w4lI9YqRVWxeyHxcWvZ+Cb0nxaB8Y/O2iSC63AvIfk FGBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si14830114ejs.731.2020.11.17.11.20.49; Tue, 17 Nov 2020 11:21:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbgKQTT1 (ORCPT + 99 others); Tue, 17 Nov 2020 14:19:27 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:46639 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725771AbgKQTT1 (ORCPT ); Tue, 17 Nov 2020 14:19:27 -0500 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0AHJJJH6009063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Nov 2020 14:19:19 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 04E1E420107; Tue, 17 Nov 2020 14:19:18 -0500 (EST) Date: Tue, 17 Nov 2020 14:19:18 -0500 From: "Theodore Y. Ts'o" To: =?utf-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, Alexey Lyashkov , Theodore Tso Subject: Re: [PATCH] libfs: Fix DIO mode aligment Message-ID: <20201117191918.GB529216@mit.edu> References: <20201023112659.1559-1-artem.blagodarenko@gmail.com> <19A3D721-93C0-42F3-ACBA-DE15B4685F9F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19A3D721-93C0-42F3-ACBA-DE15B4685F9F@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 17, 2020 at 06:30:11PM +0300, Благодаренко Артём wrote: > Hello, > > Any thoughts about this change? Thanks. I'm trying to think of situations where this could actually trigger in real life. The only one I can think of is if a file system with a 1k block file system is located on an an Advanced FormatDrive with a 4k sector size. What was the use case where this was actually an issue? - Ted