Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1203385pxb; Fri, 20 Nov 2020 04:00:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVtU/m+345k4uT+wYYr1tx2VwaUD28LK78cwZWdh5oE04C6iT1cd05sNk1+hoD6MSnc48J X-Received: by 2002:a50:daca:: with SMTP id s10mr26836734edj.263.1605873621928; Fri, 20 Nov 2020 04:00:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605873621; cv=none; d=google.com; s=arc-20160816; b=zaRzymPsMHPLvacCsSYcAVdlFfufTDcNSjoDSPNu5UmQOs82oY8S4S3fAOWVD9gsbo uaI8vgVs7r5pUH6QMn+D4JBAK94Wo5qMtLiYBGgL8LmkNJJNYZBKSee3+dLCtSEHAuRp vA8if/Jy4D9Oul2KaOxj09KlOtNGXOaTs+Csrz0y7wFsYovnceVErFa4xpqMDbPs3qvr nC4BECTVYWg8o6zvBZPesPgxf3CNa8iOUMkCwN3tjyX1Tgvy7XzHvSO5DY4BjDM0w5yD kQdkFDZwjV/Eap6mmemOA0z11od1vX7vPAL905Gs8V2uulmNLkGPWfJhnRZeOpPKh7SW IOSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gPLPy1F4mFIwsG/+PuYtocmZY1snQ6PMD6RvKhOhruk=; b=epQafWqwdjlErJopw/g1I+e5fL90nFFAJQzm5TcuXpTJ4qtQ1mrw1m7tLbNuM4bbwN zkF9yzIDbGZICPveBBnRMSSasbj2grCjsRvlmOJQr7WjB3Vy2mZi/9L3ZP590hBP+Vhf gCRuHsp0sx/Wxi+MgD72x7Aneobdq8u3rIMgxlzTUy88ZZp0bm4FuY5CkKJ4GY3A9Iyq GIFwPSxi5fjK/vz8lJhGMQ6TZdZejK2emDqa12ur62aYg3kUjnXTe7crGnXEQfshyKLt ROiBY/Ly4x0EIMQdiaKGcV1AURKHboMW6cON0dms4ORIlY/Yg6f4oRpN8Wkm9mpcqu8b 2cnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si109717edm.148.2020.11.20.03.59.49; Fri, 20 Nov 2020 04:00:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728125AbgKTL64 (ORCPT + 99 others); Fri, 20 Nov 2020 06:58:56 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:45815 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgKTL6z (ORCPT ); Fri, 20 Nov 2020 06:58:55 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kg53v-0000wK-0F; Fri, 20 Nov 2020 11:58:47 +0000 Date: Fri, 20 Nov 2020 12:58:44 +0100 From: Christian Brauner To: Christoph Hellwig Cc: "Darrick J. Wong" , Alexander Viro , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Jann Horn , Seth Forshee , St??phane Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-audit@redhat.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120115844.h732hi5p3ullzfvs@wittgenstein> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> <20201120091247.GA14894@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201120091247.GA14894@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Nov 20, 2020 at 09:12:47AM +0000, Christoph Hellwig wrote: > On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > > Maybe you didn't see this or you're referring to xfstests but this > > series contains a >=4000 lines long test-suite that validates all core > > features with and without idmapped mounts. It's the last patch in this > > version of the series and it's located in: > > tools/testing/selftests/idmap_mounts. > > > > Everytime a filesystem is added this test-suite will be updated. We > > would perfer if this test would be shipped with the kernel itself and > > not in a separate test-suite such as xfstests. But we're happy to add > > patches for the latter at some point too. > > selftests is a complete pain to use, partialy because it is not > integrated with the framework we file system developers use (xfstests) > and partially because having the test suite in the kernel tree really > breaks a lot of the typical use cases. So I think we'll need to wire > this up in the proper place instead. Ok, I think I can basically port the test-suite at the end of this patch series so that it can be carried in xfstests/src/idmapped_mounts.c I'll start doing that now. It would make it a bit easier if we could carry it as a single file for now. Christian