Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 23 Nov 2020 21:12:44 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Saranya Muruganandam <saranyamohan@google.com>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
        Wang Shilong <wshilong@ddn.com>,
        jenkins <devops@whamcloud.com>, Maloo <maloo@whamcloud.com>,
        Andreas Dilger <adilger@whamcloud.com>
Subject: Re: [RFC PATCH v3 50/61] e2fsck: move ext2fs_get_avg_group to
 rw_bitmaps.c
Message-ID: <20201124021244.GM132317@mit.edu>
References: <20201118153947.3394530-1-saranyamohan@google.com>
 <20201118153947.3394530-51-saranyamohan@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201118153947.3394530-51-saranyamohan@google.com>
Precedence: bulk

On Wed, Nov 18, 2020 at 07:39:36AM -0800, Saranya Muruganandam wrote:
> From: Wang Shilong <wshilong@ddn.com>
> 
> A bounch of ext2fs_get_avg_group() unused warning messages are
> annoying, move it to rw_bitmaps.c to make gcc happy.

This should be merged with the commit that initially defined
ext2fs_get_avg_group() in the first place.

More generally, *all* of the "fix *" commits should be merged with the
original commits.  This will make it **so** much easier to review the
commits.

							- Ted