Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2067204pxu; Tue, 24 Nov 2020 16:25:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWjfpwpNfpWV1IdsnTTWI5ndGtKhQo0ErNzaSNxBldmNmOFMSLYbHwqBT8dGpJlCFvot2/ X-Received: by 2002:aa7:d54a:: with SMTP id u10mr1118028edr.168.1606263959801; Tue, 24 Nov 2020 16:25:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606263959; cv=none; d=google.com; s=arc-20160816; b=irQ0HLjrQ6YJJMLFQxtkldvsrg35kXyerVKQTYPLYDd+L5kodFmo8Or/34tOIE1N/c 5ZO1xbCV/pIBdThYGTm+WD2GCHhCBdydUsLYiOdL6Dpa0pYyaiXQtHsIQZes4T9CDG0C zU81HSUcfuRccGpSXtvNywo2a6o+P7ZIPyrRiJ0FMpt96NAyvcmUiABhngokMGLMoJCh OqSuH9VFK2w4R6W9PovoIj/ZZGYSEKcy4Xi71tUOv9Qt6Sqai4Z8ZMAXkkqegjXgG4kj Vx0W/Ld33rceGIcBmuAtpJK26SvUZYlO3cOrjh7RhOT4diAZ/cUNxlVMDfDBZOMWLz3T ue3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CkLLL8hikHfynw+9m5cwuXiG8pYsioDRQcitRb0ZROM=; b=sSmJuZVOOpl+6m/I1V6e5+1em4AzdKUxdNlff+RbfigzQEUDvfLW8Q1d0In2xfhRZu CgcJR8ZxWqEhdX/KRWWZgWcm/9/23L4naZFt3RFVYat8GNatq3VfARj9NfHnk8YwDPMf jXaZT9Firdef4m1oCeuyet9REzA0sj/kyeV1A98ZfCwyyp1+1USd3IoKxocD0JWpkJ6K t9Vh9RnkR4kEDpt8kPI8oZ6xNhk+V52wTX9WZECZtVpA/L01mIX/gMW0ij8vISGXzRvr INmHx2vlBUMu6T53PS0XeI/VZlgPEvecXrtKWn205UpCWFIBfxO3FPKKj6zQ35aFBp03 lu6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="LXljaE/j"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si332622ejj.45.2020.11.24.16.25.37; Tue, 24 Nov 2020 16:25:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="LXljaE/j"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbgKYAYw (ORCPT + 99 others); Tue, 24 Nov 2020 19:24:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:35430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727363AbgKYAYs (ORCPT ); Tue, 24 Nov 2020 19:24:48 -0500 Received: from sol.attlocal.net (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AF542173E; Wed, 25 Nov 2020 00:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606263887; bh=ABvDlXMwjRq5govS1GsOlH9NgSkx2Q1+FWd/EUcY1U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LXljaE/jMVXFHaMrkVVLTTRANdzCOz4et9MOVW8G6aVFZLsykL8yQST5y0NwuNDwP 8vTr++uc04ONtcJUMiq+jHlS5K4vPYzlvAEWuu0e2oRUhqlKTIXzqUas8qwdmGWZ6N 3m9HsnYwlQrmNxSuDRq/lS/nzCIBKAHdPUMz7s6k= From: Eric Biggers To: linux-fscrypt@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 7/9] fscrypt: move fscrypt_require_key() to fscrypt_private.h Date: Tue, 24 Nov 2020 16:23:34 -0800 Message-Id: <20201125002336.274045-8-ebiggers@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201125002336.274045-1-ebiggers@kernel.org> References: <20201125002336.274045-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Eric Biggers fscrypt_require_key() is now only used by files in fs/crypto/. So reduce its visibility to fscrypt_private.h. This is also a prerequsite for unexporting fscrypt_get_encryption_info(). Signed-off-by: Eric Biggers --- fs/crypto/fscrypt_private.h | 26 ++++++++++++++++++++++++++ include/linux/fscrypt.h | 26 -------------------------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h index a61d4dbf0a0b..16dd55080127 100644 --- a/fs/crypto/fscrypt_private.h +++ b/fs/crypto/fscrypt_private.h @@ -571,6 +571,32 @@ int fscrypt_derive_dirhash_key(struct fscrypt_info *ci, void fscrypt_hash_inode_number(struct fscrypt_info *ci, const struct fscrypt_master_key *mk); +/** + * fscrypt_require_key() - require an inode's encryption key + * @inode: the inode we need the key for + * + * If the inode is encrypted, set up its encryption key if not already done. + * Then require that the key be present and return -ENOKEY otherwise. + * + * No locks are needed, and the key will live as long as the struct inode --- so + * it won't go away from under you. + * + * Return: 0 on success, -ENOKEY if the key is missing, or another -errno code + * if a problem occurred while setting up the encryption key. + */ +static inline int fscrypt_require_key(struct inode *inode) +{ + if (IS_ENCRYPTED(inode)) { + int err = fscrypt_get_encryption_info(inode); + + if (err) + return err; + if (!fscrypt_has_encryption_key(inode)) + return -ENOKEY; + } + return 0; +} + /* keysetup_v1.c */ void fscrypt_put_direct_key(struct fscrypt_direct_key *dk); diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h index b20900bb829f..a07610f27926 100644 --- a/include/linux/fscrypt.h +++ b/include/linux/fscrypt.h @@ -688,32 +688,6 @@ static inline bool fscrypt_has_encryption_key(const struct inode *inode) return fscrypt_get_info(inode) != NULL; } -/** - * fscrypt_require_key() - require an inode's encryption key - * @inode: the inode we need the key for - * - * If the inode is encrypted, set up its encryption key if not already done. - * Then require that the key be present and return -ENOKEY otherwise. - * - * No locks are needed, and the key will live as long as the struct inode --- so - * it won't go away from under you. - * - * Return: 0 on success, -ENOKEY if the key is missing, or another -errno code - * if a problem occurred while setting up the encryption key. - */ -static inline int fscrypt_require_key(struct inode *inode) -{ - if (IS_ENCRYPTED(inode)) { - int err = fscrypt_get_encryption_info(inode); - - if (err) - return err; - if (!fscrypt_has_encryption_key(inode)) - return -ENOKEY; - } - return 0; -} - /** * fscrypt_prepare_link() - prepare to link an inode into a possibly-encrypted * directory -- 2.29.2