Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1261034pxu; Fri, 27 Nov 2020 03:36:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1DiJsz1BlyUXEKTbuAOK/Q8+YaXnUcK12wHJBhEAvQwmsOZvBovM3Pz5rcq9ObcOui4SX X-Received: by 2002:a17:906:2932:: with SMTP id v18mr7111556ejd.144.1606476998759; Fri, 27 Nov 2020 03:36:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606476998; cv=none; d=google.com; s=arc-20160816; b=CnByCaEbDuUk2YUoAUi37SUlZS9yuu5DU50RUeRwr1a3HIaL+7KDqzb3Qlu5Bsmngl BXE9J+YAhS0EvgDsnHsG88pAyB5ESGqzbbnp1aRs9QImojvvQCG8WFS0olCl2XrUSNKq KGnh/7HOs3igshJjFBYF+hBtSWQcEqwPp2Lj7wQB10I+GmXq5m+HoQPiW54Dx323lSHU ltQYqBU73QoOD2wUJynL73x+LKMXj8NVYA0RUXo9yap+M3SLzg0bHmkdAt6exHXJFotD QUaXc9oKv4ZU2a5SK+bVZpjWdP3NUlccnXlOz7RapHNZp2KJ/e+3BbWIwRKDOldYi9a8 kfsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=mwgCs0fsDuaNXsazqevsvpfMujVawL2to8n7XuiNJWo=; b=VJ0H5uZk7BLX8xV6+kbbEgdb3V+ePB3JuMSj+6ok0tKc+/R8viohm6AWBFOpbv5EvF dX0CGxSH/+kR9S/3alvrnCu7RlG/jm71vYVRaETaycBsjgIyrg/KbShA71R2Pm83Pl/6 F16+wgX57Muj013gIk99SqMUWs9OvNK16q73Q96UvIaLDPuZ4ALZkri4DyjtjWTF/DfO wbhKSazk4VIxf9D6CiyTV+uckYANq8Gfw2wl4BRAcW3tfffDx8yG4hh7vr2ismSQVj4S OqAWYoxZgEuXgncA5OGCBh/inTSzl/GQQXJIQXbU8LRyXpyoVlWUgLAyo9rKy9qFOU7o qeBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p21si5073670ejx.516.2020.11.27.03.36.15; Fri, 27 Nov 2020 03:36:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729363AbgK0LeK (ORCPT + 99 others); Fri, 27 Nov 2020 06:34:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:51520 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727737AbgK0LeJ (ORCPT ); Fri, 27 Nov 2020 06:34:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 249DAADA2; Fri, 27 Nov 2020 11:34:08 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id AE3941E131B; Fri, 27 Nov 2020 12:34:07 +0100 (CET) From: Jan Kara To: Ted Tso Cc: , Jan Kara Subject: [PATCH 02/12] ext4: Remove redundant sb checksum recomputation Date: Fri, 27 Nov 2020 12:33:55 +0100 Message-Id: <20201127113405.26867-3-jack@suse.cz> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20201127113405.26867-1-jack@suse.cz> References: <20201127113405.26867-1-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Superblock is written out either through ext4_commit_super() or through ext4_handle_dirty_super(). In both cases we recompute the checksum so it is not necessary to recompute it after updating superblock free inodes & blocks counters. Signed-off-by: Jan Kara --- fs/ext4/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 2b08b162075c..61e6e5f156f3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5004,13 +5004,11 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) block = ext4_count_free_clusters(sb); ext4_free_blocks_count_set(sbi->s_es, EXT4_C2B(sbi, block)); - ext4_superblock_csum_set(sb); err = percpu_counter_init(&sbi->s_freeclusters_counter, block, GFP_KERNEL); if (!err) { unsigned long freei = ext4_count_free_inodes(sb); sbi->s_es->s_free_inodes_count = cpu_to_le32(freei); - ext4_superblock_csum_set(sb); err = percpu_counter_init(&sbi->s_freeinodes_counter, freei, GFP_KERNEL); } -- 2.16.4