Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Dec 2020 09:15:57 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     "zhangyi (F)" <yi.zhang@huawei.com>
Cc:     xiakaixu1987@gmail.com, linux-ext4@vger.kernel.org,
        adilger.kernel@dilger.ca, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] ext4: remove redundant operation that set bh to NULL
Message-ID: <20201203141557.GG441757@mit.edu>
References: <1603194069-17557-1-git-send-email-kaixuxia@tencent.com>
 <2677070f-f994-f20d-115b-55922d172da6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2677070f-f994-f20d-115b-55922d172da6@huawei.com>
Precedence: bulk

On Wed, Oct 21, 2020 at 09:10:18AM +0800, zhangyi (F) wrote:
> On 2020/10/20 19:41, xiakaixu1987@gmail.com wrote:
> > From: Kaixu Xia <kaixuxia@tencent.com>
> > 
> > The out_fail branch path don't release the bh and the second bh is
> > valid only in the for statement, so we don't need to set them to NULL.
> > 
> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> 
> Thanks for the patch. It looks good to me.
> Reviewed-by: zhangyi (F) <yi.zhang@huawei.com>

Applied, thanks.

					- Ted