Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp13538pxu; Thu, 3 Dec 2020 17:47:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJztxGLQYYOKMo0nMAjQrJGkVKGxlTqexphXR88qqHuFAWBHggYhWZQSXwKzH7ADe3lDLO2N X-Received: by 2002:a50:d2c8:: with SMTP id q8mr5165650edg.375.1607046422578; Thu, 03 Dec 2020 17:47:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607046422; cv=none; d=google.com; s=arc-20160816; b=Y4j323YRxgQsbzqETyT4k19Z2NSeOqZVP4oCwxJESpam0xyOixdPuYcwK7uhcHulLQ IazdZLxID1AXv5Hy0+XTlYAhd0UKlltacj7ZbraTpQF5osXjvfUvU65t+IplUQB64zzx yGiM4ZpxqCY8aQtWpHcKwGbNrcrKlQcXwjzWYVhjpyrOL14bgBLxD2xAs2DXHNNtr+jg prHM+ASquoNI+YnJflIEf+HHkEP4co+HMMetzq7uqk8W4GTL7v40j2jY5hn98cctB4ON ZXYNz0L8Wy75e3QXFJQz/Hr+UgWseDT/vcFZDH1/JlVGjz/4+t1q/0UOS+90rtBWdvIK YhCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=0Jj0Xmjfa8KBObh/OML4zKsQa9Xee9p49u+fOpF0qJg=; b=JbRAeCQLWi0EPTwMvxpzlNML8DGW3LmaG4DQP68cEmri7RwLVBTRdDG5jk18M0+Imf SYMbN6ibWI33fdbtmUSO6XqUX5gv1vMXQVKXIeazu3otG5wdP5wIW/c5TSkaoXB3Ri12 BCkE73tmzvwzhWKEIsj8JLf+eEo4GsatvSeL9++TFnp1Z0aEZGMpxWrfD3IId+YTek8Y v5eV7dENaWAWVBHB+RqFlBnI9QqQ8PEsJykRU+/O2QTbTlhrV3pHHOtXLnDtC7HqZGw+ Xt7cvUGXYdzGG7qLGRQbPnF7Zhq7mSTUiYYFuR8v9dvO6EtxEDHOdsRtox6YNLiiNWHv oyww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs31si155659ejc.337.2020.12.03.17.46.27; Thu, 03 Dec 2020 17:47:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbgLDBpV (ORCPT + 99 others); Thu, 3 Dec 2020 20:45:21 -0500 Received: from mga06.intel.com ([134.134.136.31]:22953 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLDBpV (ORCPT ); Thu, 3 Dec 2020 20:45:21 -0500 IronPort-SDR: Jzy7hgoFvCwEvhfL1SOvWeK+Y/VUtYQQIFp4FpNsaF2NQoJJ/rlqtO927JIw+OU92gXJ3fs6UQ zX1bwPIimnGw== X-IronPort-AV: E=McAfee;i="6000,8403,9824"; a="234917597" X-IronPort-AV: E=Sophos;i="5.78,390,1599548400"; d="scan'208";a="234917597" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2020 17:44:39 -0800 IronPort-SDR: Mcyx6D3nTWzTvO62HGuIWnhDH61K3QPnToO9ehSCOjzrP6vE+6CubJn4BHBf5TPwi1z2rwyT5L gRoCR+h9HxLg== X-IronPort-AV: E=Sophos;i="5.78,390,1599548400"; d="scan'208";a="482195127" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2020 17:44:39 -0800 Date: Thu, 3 Dec 2020 17:44:39 -0800 From: Ira Weiny To: Christoph Hellwig Cc: Eric Sandeen , fstests@vger.kernel.org, Eric Sandeen , linux-kernel@vger.kernel.org, "Darrick J. Wong" , Dan Williams , Dave Chinner , "Theodore Y. Ts'o" , Jan Kara , Jeff Moyer , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Howells Subject: Re: [PATCH] common/rc: Fix _check_s_dax() Message-ID: <20201204014439.GE1563847@iweiny-DESK2.sc.intel.com> References: <20201202214145.1563433-1-ira.weiny@intel.com> <20201203081556.GA15306@lst.de> <20201203180838.GA25196@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203180838.GA25196@lst.de> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 03, 2020 at 07:08:39PM +0100, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 11:55:50AM -0600, Eric Sandeen wrote: > > *nod* and my suggestion was to explicitly test for the old/wrong value and > > offer the test-runner a hint about why it may have been set (missing the > > fix commit), but we should still ultimately fail the test when it is seen. > > Yes, that's what I'd prefer. Sorry for the misunderstanding. V3 on it's way. Ira