Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2551974pxu; Mon, 7 Dec 2020 09:19:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyuX9EyVumyJR1P6Ekd8tPG/b3orJAZ2j7E4ITxK4+Bz2i4csLzGqBXPG99RC5MgBj/Tmpy X-Received: by 2002:a17:906:895:: with SMTP id n21mr19661429eje.52.1607361575649; Mon, 07 Dec 2020 09:19:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607361575; cv=none; d=google.com; s=arc-20160816; b=LlQibjjW4qIf7lh5Ap2vm6j+TXSitG9LUu4zJwLL4YrFBYPHYwNOZmMpWoa7UWS+OX 4Gd815Je9aL9R86zwOFs3Ld96XuV8uBr7D7agMNuwKfO8eXrW7PsUwadIr5K/oN5HEr7 EkzjHdID31MF6UxbZplABXTGQJzfVrUB6e4JPWhy26de0f4lHhz1tJcmohXzyG1Wu4zk K+z5E4CuuCgwrJzUmwavDvsB0ajGBCZc1zVX1T/kh4ZlqxNRAA1TqYRFAWyFdiU+cpG8 Cvp1r54/Q3An/9F+5fva+Vn25q8Ezz126yeM6xu0naz8qxHpF/PXuBLtyHDwTKA3XHey Htvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:organization:subject:cc:to:from; bh=eFwCUX9oi4uzUCAQKLHuPIYMeSU9dxRATU69IkstSpI=; b=KI3NbWhdr0lFV4qAa1td+Dduae6sHTxfrcPm/dWvJA7VNNfJh99oT2nv8HL/MdeJzf Ya4Gqh17s1olvVswVlNjNCzLy4zBvGg6EwdmlgQI29wqS+pGHJfJy6CQyla5swbpQiQy WRhwndRs+HIYHnK/QQ4MbdIWCX3F3zwf8xrtmcteOwvYBXXFUEFDdq/ARn7RgXxapL7W FiGm/SA6QP6zi2j2X4u8krsAcmp4jkrWmGVPlB8169EN9VM4b7nL+xlLTb4Z3QnIfyq3 ALXH+Zkrs8HZgilVzykEIUaE2aB3EqO/wQWu/HoCJtxGfQk6p4/6pd+LVe0weFzw9SBa ORGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si2872534ejr.272.2020.12.07.09.19.09; Mon, 07 Dec 2020 09:19:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727235AbgLGRSG (ORCPT + 99 others); Mon, 7 Dec 2020 12:18:06 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52650 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbgLGRSG (ORCPT ); Mon, 7 Dec 2020 12:18:06 -0500 Received: from localhost (unknown [IPv6:2804:14c:132:242d::1001]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: krisman) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 084331F44D13; Mon, 7 Dec 2020 17:17:23 +0000 (GMT) From: Gabriel Krisman Bertazi To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, Daniel Rosenberg Subject: Re: [PATCH v2 01/12] tune2fs: Allow enabling casefold feature after fs creation Organization: Collabora References: <20201127170116.197901-1-arnaud.ferraris@collabora.com> <20201127170116.197901-2-arnaud.ferraris@collabora.com> Date: Mon, 07 Dec 2020 14:17:19 -0300 In-Reply-To: <20201127170116.197901-2-arnaud.ferraris@collabora.com> (Arnaud Ferraris's message of "Fri, 27 Nov 2020 18:01:05 +0100") Message-ID: <87o8j57cyo.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Arnaud Ferraris writes: > From: Gabriel Krisman Bertazi > > The main reason we didn't allow this before was because !CASEFOLDED > directories were expected to be normalized(). Since this is no longer > the case, and as long as the encrypt feature is not enabled, it should > be safe to enable this feature. > > Disabling the feature is trickier, since we need to make sure there are > no existing +F directories in the filesystem. Leave that for a future > patch. > > Also, enabling strict mode requires some filesystem-wide verification, > so ignore that for now. > For some reason, I wasn't CC'd in the cover letter, only on the patches themselves. Anyway, in order to get more/the right attention, I think you should CC Ted and Eric Biggers on the entire thread. Can you send a v3 with a proper CC list? I haven't taken a second look at the patches yet, but it is no my to list. -- Gabriel Krisman Bertazi