Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 17:37:23 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@dilger.ca>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>,
        Saranya Muruganandam <saranyamohan@google.com>,
        Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH RFC 5/5] Enable threaded support for e2fsprogs'
 applications.
Message-ID: <20201211223723.GD575698@mit.edu>
References: <20201205045856.895342-1-tytso@mit.edu>
 <20201205045856.895342-6-tytso@mit.edu>
 <89A599C9-4978-43C9-B2B4-82C9E746AC39@dilger.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <89A599C9-4978-43C9-B2B4-82C9E746AC39@dilger.ca>
Precedence: bulk

On Thu, Dec 10, 2020 at 09:10:09PM -0700, Andreas Dilger wrote:
> On Dec 4, 2020, at 9:58 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> > 
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> 
> My understanding is that as soon as the EXT2_FLAG_THREADS is added,
> and if the backend supports CHANNEL_FLAGS_THREADS, then the pthread
> code in the previous patch will "autothread" based on the number of
> CPUs in the system.

Yep.

> That will be nice for debugfs, which would otherwise take ages to
> start on a large filesystem if "-c" was not used (which also
> precludes any kind of modifications).
> 
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>

Yes, that's an issue that our SRE's have run across as well while
debugging customer problems, which is one of the reasons why I've been
interested in getting this change upstream first, even it takes a bit
longer to get all of the parallel fsck changes reviewed and upstream.

       	      	     	 	  - Ted