Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2808278pxu; Mon, 14 Dec 2020 11:21:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzL6sdU9H2bsopOduBJibjlLLrdPueDdX6zciq8Mc4XGDbqtcIyp25dKp5hIR/ky+3BNCmr X-Received: by 2002:a17:906:3099:: with SMTP id 25mr23866342ejv.321.1607973660105; Mon, 14 Dec 2020 11:21:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607973660; cv=none; d=google.com; s=arc-20160816; b=Fli5QtpfdoQTKgKVe9Y5ke1lE2wCSU/kcoXH/j/afi1zKR9nnsAplv8+WBXcVwhZdF Q9rygQxx7Xkk+q6ixzrVGH8HoOGlFYbeRl1kN1nXwppOjHu7PuNdE1hi8yBY0Dgzopw2 n7n413RGlYNGVuIVhdWVyo4oQfM1siVjm9R9/zX0ZcX5VogSY4fiJJo3XWXmnF4khfUx M+0rYruxPdRxn0B0rHh2/7F40ZbqPA7qgJwq3/hqykWLPL7ItZQ4xJ4P/HCjENqYs/VG fimnuEqOcJeNcTa3IQfwuMtBGPsE9c28ioH8TL8cRhBw3gbSKIFjJR8qGjl72xdU2Lfv VYwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=xuR72zkNhchqQVbvXo1Nmv8jsLcpHYpwxJu9BP6CJOs=; b=MOkJBFkFTsfVjz2VD+d5mvyiTfboUJB6oBWPOHEe2rDr2j3wFe2kkMSXH9BHojbCUQ LG3c5PBIgY1LFUUo5bmsKMlaLanCjosrUA1TE3I7BKCl1c5Ue/2rpU4swouhr9v8AxAc wqlRm1wzqp/ygSRgeVrIzt4tKiNHySlgNTQMQcpgIfMdzoXQ0+e8XYc+syeFDQhQbCBv zSPsLI47c0ZB5jc4evULAY1LT4IIwR0emsdwfOgEyOJhMNCNo3mjO4cTX8m6mIkjW6L7 tX+n1VLIBMNpD+Ydr8NKYuHjdiZp7qlFry8iHquv+6lFmRxvP6EOhsIveBTZ8Q5H5m2x LT1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XjNZnCoV; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j16si9584881ejc.358.2020.12.14.11.20.33; Mon, 14 Dec 2020 11:21:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XjNZnCoV; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408935AbgLNTJI (ORCPT + 99 others); Mon, 14 Dec 2020 14:09:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408917AbgLNTIv (ORCPT ); Mon, 14 Dec 2020 14:08:51 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53C85C0613D3 for ; Mon, 14 Dec 2020 11:08:06 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id n26so24052738eju.6 for ; Mon, 14 Dec 2020 11:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xuR72zkNhchqQVbvXo1Nmv8jsLcpHYpwxJu9BP6CJOs=; b=XjNZnCoVXZnnlgKpBGOi0WS3uKEqlPClQ7qEtmkb8olrpnuP4nSN9HgL11QG+EklX6 +TcC0x4667374m1UFDeY8sGrF5XxfnW+jiFRtztpfNna1R06NSCCO5jFQJXoSve+wnRI k56l5PXqeipZWUglJT6UQXXAJKYeL1zVFHS7//z+hF5YS6euYIiaCpEALEsk4sQfv+Rl SXURvTF5Ov7uhq/Ib09wKtWaJhdfNYeaXpiQAxfdx2nDp6yQhmNTa6bdd/d/2/EtstgX R6XBfvBiLg/nfhVCAR5FeG8Z6jlf9isS8nQRKq26twVZrPKGKt++riaqFUfi6xGrwjHW Vq1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xuR72zkNhchqQVbvXo1Nmv8jsLcpHYpwxJu9BP6CJOs=; b=maHzghcr++0/rYMXiWybVx73TsRv18mn+tBT4DQA53QZLFe6qKU+Nqi/2FxMnK6zpd om1Lf2vTlee+Jxv1LQQ7HgnpyS0H24uh8xdRmcI5l4VNMsgT9I+3QxrZGa+2yb8PQwiX zmILurFfp175KQjzjM3W0SW5fh8I6UP3jAg/jz1Ex5DcDTuiVI2yyuHs1ZvpvES2ILlZ jXjPjHuACydK+lUFRgRPHUXSvIovOk6EX/5Xq+Bbx/3or/cswPgjuqBreEhYsHP8RiJ0 sZV7wQv/IuCv6xiIAx7E2Aknbi6uRvoGlsbpsj4zLY6xfVmmp12lhNMCF4Pocfv5Q9/9 0iCw== X-Gm-Message-State: AOAM531rr9Y7amkzC8hZjAkx39lMjhID7CtVfMOIc7QzcrnKO2s6riBN Tt9xlD9q/K5R3mPm8UVFg/4fSpWt+vddHHgvNU4= X-Received: by 2002:a17:906:4a47:: with SMTP id a7mr12968059ejv.345.1607972885062; Mon, 14 Dec 2020 11:08:05 -0800 (PST) MIME-Version: 1.0 References: <20201127113405.26867-1-jack@suse.cz> In-Reply-To: <20201127113405.26867-1-jack@suse.cz> From: harshad shirwadkar Date: Mon, 14 Dec 2020 11:07:53 -0800 Message-ID: Subject: Re: [PATCH 00/12] ext4: Various fixes of ext4 handling of fs errors To: Jan Kara Cc: Ted Tso , Ext4 Developers List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Thanks! I ran smoke tests (-c 4k -g quick) on this series and there were no regressions for me as well. - Harshad On Fri, Nov 27, 2020 at 3:37 AM Jan Kara wrote: > > Hello, > > this patches addresses problems in handling of filesystem errors in ext4. > When we hit metadata error, we want to store information about the error > in the superblock. Currently we do it through direct superblock modification > which can lead to lost information, checksum failures, or DIF/DIX failures. > Fix various races in the error handling so that the superblock update is > reliable. > > The patches have passed xfstests for me in various configurations and some > targetted manual testing of the error handling. > > Honza