Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Dec 2020 13:50:27 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     Andreas Dilger <adilger@dilger.ca>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation
Message-ID: <X9kFc9S/JnHBWXsY@mit.edu>
References: <20201013133848.23287-1-jack@suse.cz>
 <43B157BB-33E4-4D82-8A09-0E1BCACC55D9@dilger.ca>
 <20201015092731.GC7037@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201015092731.GC7037@quack2.suse.cz>
Precedence: bulk

On Thu, Oct 15, 2020 at 11:27:31AM +0200, Jan Kara wrote:
> On Wed 14-10-20 18:56:13, Andreas Dilger wrote:
> > On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@suse.cz> wrote:
> > > 
> > > Explain which valid block sizes mke2fs supports in more detail.
> > > 
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> > 
> > Should this mention that the default block size is 4096 bytes for most
> > filesystems?
> 
> That would be to the "heuristic" parts. Yes, I agree, I'll add that.
> 
> > It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
> > is definitely an improvement already.
> 
> Yeah, I can add that to the "page size" part. But with these archs there's
> a catch that page size can be configured in the kernel config so the
> formulation will need to be a bit more careful. But I'll add something.
> 
> > Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> 
> Thanks! I'll send v2.

Did you ever send a v2 of this patch?  I can't seem to find it in my
archives or in patchwork.

Thanks!!

					- Ted