Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: Re: discard and data=writeback
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Matteo Croce <mcroce@linux.microsoft.com>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "tytso@mit.edu" <tytso@mit.edu>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
In-Reply-To: <CAFnufp0zZL04L5UF_TY7+n91FjktG6Bb0J2j0f3eomXdnHGQ4A@mail.gmail.com>
Message-ID: <20201231013236epcms2p63f3c167693f76407103422d8cd347725@epcms2p6>
Date:   Thu, 31 Dec 2020 10:32:36 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CAFnufp0zZL04L5UF_TY7+n91FjktG6Bb0J2j0f3eomXdnHGQ4A@mail.gmail.com>
        <20201229054143epcms2p15ae3cce43bb3c503adf94528f354ba78@epcms2p1>
        <CAFnufp39qXBtOfETsYz5LSoPZWik70uB=czmfpwiA8Hdwpi+dA@mail.gmail.com>
        <20201230052139epcms2p5d4b8d41625ebd7ea677500d1c05153ef@epcms2p5>
        <CGME20201229054143epcms2p15ae3cce43bb3c503adf94528f354ba78@epcms2p6>
Precedence: bulk

Hi,

In the trace files, the amount of discard is almost the same in both modes.
(ordered: 1096MB / writeback: 1078MB) However, there is a big difference in
the average discard size per request. (ordered: 15.6KB / writeback: 34.2MB)
In ext4, when data is deleted, discard is immediately issued in writeback
mode. Therefore, the average size of discard commands is small and the
number of discard commands is large.
However, if it is not in the writeback mode, discard commands are issued by
JBD after merging them. Therefore, the average size of discard is large and
the number of discard commands is small.

In conclusion, since discard commands are not merged in the writeback mode,
many fragmented discard commands occur, so it affects the elapsed time of
many file deletion. And it is not abnormal behavior of ext4 file system.

Thanks,
Daejun