Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH] ext4: Change list_for_each to list_for_each_entry
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     harshad shirwadkar <harshadshirwadkar@gmail.com>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "tytso@mit.edu" <tytso@mit.edu>,
        "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
In-Reply-To: <CAD+ocbwuZ-y--YoC=1khtaQ1A2oYqyQtKGsvVHNvngzsuN0ByA@mail.gmail.com>
Message-ID: <20210111011821epcms2p626def5bccbea257ffbcd95257c1539cc@epcms2p6>
Date:   Mon, 11 Jan 2021 10:18:21 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CAD+ocbwuZ-y--YoC=1khtaQ1A2oYqyQtKGsvVHNvngzsuN0ByA@mail.gmail.com>
        <20201231015213epcms2p5ef76aa6b26ab74e045a86f6a13b31d51@epcms2p5>
        <CAD+ocbwjVsiPNnp3RShN7eRDm5ZRDMwgk5uPO1at-KeX-osyqg@mail.gmail.com>
        <CGME20201231015213epcms2p5ef76aa6b26ab74e045a86f6a13b31d51@epcms2p6>
Precedence: bulk

Hi Harshad,

> > > list_for_each + list_entry can be changed to list_for_each_entry
> > > It reduces number of variables and lines.
> > >
> > > Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> > > ---
> > >  fs/ext4/fast_commit.c | 7 ++-----
> > >  1 file changed, 2 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> > > index 5b6bb3ef0f33..dc58471971db 100644
> > > --- a/fs/ext4/fast_commit.c
> > > +++ b/fs/ext4/fast_commit.c
> > > @@ -915,13 +915,11 @@ static int ext4_fc_submit_inode_data_all(journal_t *journal)
> > >         struct super_block *sb = (struct super_block *)(journal->j_private);
> > >         struct ext4_sb_info *sbi = EXT4_SB(sb);
> > >         struct ext4_inode_info *ei;
> > > -       struct list_head *pos;
> > >         int ret = 0;
> > >
> > >         spin_lock(&sbi->s_fc_lock);
> > >         ext4_set_mount_flag(sb, EXT4_MF_FC_COMMITTING);
> > > -       list_for_each(pos, &sbi->s_fc_q[FC_Q_MAIN]) {
> > > -               ei = list_entry(pos, struct ext4_inode_info, i_fc_list);
> > > +       list_for_each_entry(ei, &sbi->s_fc_q[FC_Q_MAIN], i_fc_list) {
> > >                 ext4_set_inode_state(&ei->vfs_inode, EXT4_STATE_FC_COMMITTING);
> > >                 while (atomic_read(&ei->i_fc_updates)) {
> > >                         DEFINE_WAIT(wait);
> > > @@ -1099,8 +1097,7 @@ static int ext4_fc_perform_commit(journal_t *journal)
> > >                 goto out;
> > >         }
> > >
> > > -       list_for_each(pos, &sbi->s_fc_q[FC_Q_MAIN]) {
> > > -               iter = list_entry(pos, struct ext4_inode_info, i_fc_list);
> Variable "pos" isn't used anymore after this patch. You removed it for
> the ext4_fc_submit_inode_data_all() function, but missed removing it
> in this function. That's throwing me a warning.
> 
Thanks for comment, I will remove this. And I will change some list_for_each_safe
macro at new patch.

Thanks,
Daejun