Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp894032pxb; Wed, 13 Jan 2021 19:46:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEt6v5n/eU2u7eL2tJ2Ypitpx/iZ5M1hsg3VjwMRIe4obNzC2c27AOnLmXFOemucUUkzft X-Received: by 2002:a17:906:ae41:: with SMTP id lf1mr3866980ejb.369.1610595989316; Wed, 13 Jan 2021 19:46:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610595989; cv=none; d=google.com; s=arc-20160816; b=SWCiddybpPJYL9RGeKDVAZy9g2DUdtorh+AAtK7lCK7aMPI8wXHHV6iiTjdi0N0AEI XOADche3ARKE5YLPrKbnxbimK0eEtYcNfVo2qKVNyxVDSnGgtEqwz+zQ9EH+KPZ0bV+M qHDOulkPu8h1gWtHCgFpE6i6B601YlNapJjmTZRQQHIEJuUjBhmgrMIAzg9wFLFTv6oK QfsxJ7OC7G8CV6d6prQlE+P4mw848OQN+wZz11zeHGjoDYRCyAoH/RckFL/dNgpDXyom 7FdkUqOhLSJ6F0Lgukv/E3DTtkqvbNhl0lPuPwUPPol5I33acek25cyi/UGAaq2XMYj2 G4oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=UNIlN8uoH4eHxt35wbGXRDj98p9nLNgRRPaplyW9Kv0=; b=ob7JkWeweqFZF78wau3YkvyUs84xw2fJzkK/KukRSF9uR2PNICpIz1J8GXpdPvNATc j0BhlWGbCR4AIeZ2gVtBh0a21hzublbz3jGzIe0sPSEP0DMEHqi+osZOehHnVaeKRvu3 8JHhU4OKZ0D1fG/ZubQtQgrRPyMEH7A9qSGu/3uYDP+DenFfRDm21JwWiPe/qH3r2dQl Akm8kOAx678gXkVpaSCfZe9QaC+YljUDflGs38Lu+JmUS7TsSloleHZs3hgH5GpNYJbo Jz3hB4CSipH8JokG6we3+wqUvzt64hLscP6cbtfS5HZSSg7rGU69+cTE/SAFTWFDF2wH hhVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si1902672edp.251.2021.01.13.19.46.05; Wed, 13 Jan 2021 19:46:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726198AbhANDpv (ORCPT + 99 others); Wed, 13 Jan 2021 22:45:51 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37802 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726152AbhANDpv (ORCPT ); Wed, 13 Jan 2021 22:45:51 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10E3iwik019962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 22:44:58 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0CB1015C3453; Wed, 13 Jan 2021 22:44:58 -0500 (EST) Date: Wed, 13 Jan 2021 22:44:57 -0500 From: "Theodore Ts'o" To: Daejun Park Cc: "adilger.kernel@dilger.ca" , "harshadshirwadkar@gmail.com" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ext4: Remove expensive flush on fast commit Message-ID: References: <20210106013242epcms2p5b6b4ed8ca86f29456fdf56aa580e74b4@epcms2p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106013242epcms2p5b6b4ed8ca86f29456fdf56aa580e74b4@epcms2p5> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 06, 2021 at 10:32:42AM +0900, Daejun Park wrote: > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH > on the block that has tail. > > Signed-off-by: Daejun Park Thanks, applied. - Ted