Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3128059pxb; Tue, 19 Jan 2021 14:43:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+8YbwB993JRMg/uKNhMhn7Vsqn6YLmSOus0YFjr6EW7ZH7ElIL8kjMJjUUsK+bfkmkwQT X-Received: by 2002:a17:906:da02:: with SMTP id fi2mr4153399ejb.230.1611096196063; Tue, 19 Jan 2021 14:43:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611096196; cv=none; d=google.com; s=arc-20160816; b=YnZtJTLbPoHqye7OV1S6drIbRengJGoas2nKcZtPQbrpv9oiKAJFaqK5855eKoqc2L W26vJQ+C8qksg1pAPjaHA5MO2s4GG9DQA3WSFzjYKy3u+lmOGORpvSPqu/ToFgXCnScB 2k0gyqxynjCLvF3WobO7nZEUmZpg3Q47bxPEmMTYK8dS52ilbe49WNqG6SqCOULdu0wq 6fSpn1DQkkq2xiiQTZPlY5TFl7eS3+mcocnjVpymdww4PGJS4MUTcBOcL48DIufjXCE3 sO2XzDcGWqzNsblF6ZwILMg4GMm4lsUe7ISrdiE6+ne31BotcqgxwUfasCBGYe/xg0Ta NvBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KBLdqigwXHa9zb4IKHjzXYIBtipeYgH3IvVF9mKe8Wc=; b=tG9ng/PEQPDU5ohNgjmqxXeYlz/CPQaF+xIeSkp9Pc0a6866Fu+LP441iN/BnmonpN IKX3xhuGZxOKasZebvxNU30fGp40MNN7y4jFWMUtkdNX6dcGsybbGOCJzL1MK6vXI0rf ltdSwVmhy7GTxn/6Hefa/d07T4bhunCDDtG4em0N6dwBrKdhO2EGEvQkG3lUUsqXw5Wo xL5M2JO6ewWY8OGagTRMNkcfBU2KIfe/1UElXE83565nwDizQjd7MhYXStQSWSSJV3Y4 dmBPztu44GsaYmrSlRGu6QoG3sbFawdfTaWHU9ZxjxfyWIgEf2nR5fuD+SNUYWdzQNq2 ew/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rkMudNvW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p59si122307edb.125.2021.01.19.14.42.53; Tue, 19 Jan 2021 14:43:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rkMudNvW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405446AbhASOcn (ORCPT + 99 others); Tue, 19 Jan 2021 09:32:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388605AbhASJse (ORCPT ); Tue, 19 Jan 2021 04:48:34 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8613C061573; Tue, 19 Jan 2021 01:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KBLdqigwXHa9zb4IKHjzXYIBtipeYgH3IvVF9mKe8Wc=; b=rkMudNvWO66HMSQr1C/riYx6VA ITPbSZKgiBW4KcAtUmJmkUr1dBGlA/LNN3BGZBcxy4D6iuF9UCTZW8+fvX6Fs2HjXaH7Id164/C6p 8aX7aQWKUIb43BuHAt825NJDtfHZ03eFtv7j69IJStn2YxsSOCpKR6Ec83TqhIMYX2rT5ua6MVffv dkDjTkT8HY7yNCIjlZIOXXuGVjfTfypwT0jzue7d0zu6Oqjhs9YmICue9ulItMg+VcpccEHVuyhvT Git07uadZsjuEsjKkGCVR9P2D1ctpz0L0F93Xqf5Qcom70CCTkD4H7p/+v1MyKeAUkCnqLSoSIzQN d/kOWGMA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1nc6-00E8cK-3V; Tue, 19 Jan 2021 09:47:50 +0000 Date: Tue, 19 Jan 2021 09:47:50 +0000 From: Christoph Hellwig To: Christian Brauner Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , St??phane Graber , Linus Torvalds , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, Christoph Hellwig , Mauricio V??squez Bernal Subject: Re: [PATCH v5 40/42] fs: introduce MOUNT_ATTR_IDMAP Message-ID: <20210119094750.GQ3364550@infradead.org> References: <20210112220124.837960-1-christian.brauner@ubuntu.com> <20210112220124.837960-41-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112220124.837960-41-christian.brauner@ubuntu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Generally looks good, but wouldn't it make sense to introduce the userns_fd in version 0 of the mount_attr structure instead of having two versions from the start?