Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3128996pxb; Tue, 19 Jan 2021 14:45:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1oCpjsmhDRy3mJxzEO75txbo6vJ9cYcg/NqE5bCA2AFYnV8DPcJHf9Ihq0jkzfKhsrMKs X-Received: by 2002:a17:907:3345:: with SMTP id yr5mr4340711ejb.50.1611096308943; Tue, 19 Jan 2021 14:45:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611096308; cv=none; d=google.com; s=arc-20160816; b=UgUwQO/F+GyDvdlilL8HKXQq7tlGn6zKJ2zReINFonR8K6UYWX40RwF8VA3MA2RADz FT+gI6sJiaq2pvpxX1YnH7CE7eNj4DNgDke78bqiFIgT/0dRk2Cn0ZXuv9Zfl2MNfZ4U LhgQqsAe/IUxjr40uy/rpGl6p0detWEN5BQ/ZTVEZm/BUZPtFBWKesFzul0boCitaiG4 MTIIbBRS8ElKsAf8iONzzqwYCZLa3Xm4rmOX2HGO1KRpzUOuQgRQble4XcHFC+8P7YOp GFHd6kNH70dWbUSxvnLsrTrsuHTFvdpLsFdXfXx6sKLmRuHW2Vd+u6a83aO7TSh96dyH XP1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lPUT4BIPvjjCigfj+gwWcq84YOMCaUD9YUasmcIOtgU=; b=WJ0GR/XWpcZBcOoVmBboSdKQiogtGJa8JmfvRPZ7IrG9LTbzfe6yJLJHGBSDjTO3Ol KX5o2ggd7EpFU9zMOPk9hpNB2yvu2ClLOnIS9q0sgp/ExZqEG6GahLMvdXFEIuPF5+oK Np+MBhw1cUvMGZY6Nf4srH/UpZCUyst21eJBgJmVsqSD7kzzXYfl6mMotlbBcge6HSPS UiqpF7eoEVFePpARWmK0Hxs892z1gpdulWdlq+uHtsK0hGPkwND6aWi8O7wFRl/mIQi9 Hj508D/WSQtfhxqKtnYHCRTlNQ2lQdMrONItfuxD65FkCnuIDI65rkq9oOSocl2Fwkt0 2zFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kC5U3uMC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si47131ejc.418.2021.01.19.14.44.45; Tue, 19 Jan 2021 14:45:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kC5U3uMC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405129AbhASOc1 (ORCPT + 99 others); Tue, 19 Jan 2021 09:32:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387895AbhASJo7 (ORCPT ); Tue, 19 Jan 2021 04:44:59 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F4FC0613D3; Tue, 19 Jan 2021 01:44:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lPUT4BIPvjjCigfj+gwWcq84YOMCaUD9YUasmcIOtgU=; b=kC5U3uMCKrCdQwzr7bsvxcfxzm fewFkXAHif7op94rMpcMd8CgWPxuymKRh0r3QdzGeQWVjr0hvAx3gYLfYrHzQuSBWrfRqg4oQSFzm aqrdqutN/oRSFc3xFbv6tnqZjEp/dsdqkftL/qzUtB4vv2p6XPRAXfWDEf3UqaigjmYarQ4FyypZD PBhQRburzoHMPRsPVBRntHEeZtZ0WugF3YP+PvRkiLFxqxPCK7M5a5Is6txx2oOF17qQ9omG170Iq XKrtxwJ34xba9qhgS8V2a2FWK5Af/bAmlUfHIVHQszylYqdLO4bf4ppjo82Bkwcxq/oyhEZukD+T/ gTTYD9GQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1nYQ-00E8Km-9k; Tue, 19 Jan 2021 09:44:02 +0000 Date: Tue, 19 Jan 2021 09:44:02 +0000 From: Christoph Hellwig To: Christian Brauner Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , St??phane Graber , Linus Torvalds , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v5 29/42] ioctl: handle idmapped mounts Message-ID: <20210119094402.GM3364550@infradead.org> References: <20210112220124.837960-1-christian.brauner@ubuntu.com> <20210112220124.837960-30-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112220124.837960-30-christian.brauner@ubuntu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jan 12, 2021 at 11:01:11PM +0100, Christian Brauner wrote: > Enable generic ioctls to handle idmapped mounts by passing down the > mount's user namespace. If the initial user namespace is passed nothing > changes so non-idmapped mounts will see identical behavior as before. Looks good, although file_permission would help here as well.. Reviewed-by: Christoph Hellwig