Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3132808pxb; Tue, 19 Jan 2021 14:53:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfHJu1ziG5EAyyPEGXdJffNr20g+r1acspXdEGxjYokE0zj14w40DtM/tVWVvC1useoigF X-Received: by 2002:a50:fd19:: with SMTP id i25mr4965409eds.386.1611096808198; Tue, 19 Jan 2021 14:53:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611096808; cv=none; d=google.com; s=arc-20160816; b=Kv9SOLP1iz3yPWvHp3kZWZslE+4f8bPHp9Zog+jjOlwsfKZcsqL9DCdB+XZszOpx71 iWKw7kE5w6GfwJNghzlV+avfg4HCMhuDmpK8o7QQb92CL1IG3nQ3szVH/jr+o/c4ajoq gnOG/GxxUoyu/daC55WORezMQXYA2zO7nSnrzsrdyI2GUwtsrDwRosmJBzIS+XZdazlD hnk91StQ5MJ9B8wHJZMys7NCgCcan9dMO+XDWsuSpBb5JG8KxPxZDmsA+t87ChisyGga WSc9vBf4BdwWkzViNTOPZDC3BCex7c+TNlllFHC3xwDmWOs/wHRep6T67yCe13E13Bfd 8oKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q/D2JdF5j8WZ+eKrcjnyASbc7aIzC7mYZI2IulQrCZ0=; b=pqH7A31tZgOwUjnR6O26FMNrwhsxl5omoDGNinctM4r+l+Oz8yTkW98bRnQLHgdA2r YRwKr57S7htYZRlaL/V0oV3Q+kbe9g3APZA6M7lRZoSXv8oDHTUF3FXLdR17WoKJOamw jSA3+P/z+nJsiE+H9qK1BNm3ttNyyH2xS5xmjp4gnMOtr42kawbhnU3LQpDkUCQ9lg1q grVXo8ng6UrbJLcGKoOumJatXdUGjn6XZRgU/gt4I0BRHGWA9RDU1sIJr1AR0B+UqNp2 DAOUC4/e0P48o7LO+9n2BYZxhoBRxYV1gNcBwSliUgvF7tG9+FvKWmJHFaL6nfShiIp9 GKKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=pYLEJ7WC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t17si102730edc.421.2021.01.19.14.53.05; Tue, 19 Jan 2021 14:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=pYLEJ7WC; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392033AbhASOaW (ORCPT + 99 others); Tue, 19 Jan 2021 09:30:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbhASJju (ORCPT ); Tue, 19 Jan 2021 04:39:50 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2783C061573; Tue, 19 Jan 2021 01:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q/D2JdF5j8WZ+eKrcjnyASbc7aIzC7mYZI2IulQrCZ0=; b=pYLEJ7WC/RXDg1o4DBU2/cYVuP Thgszt4zS9vHR1ZzFkVfHFaq1An+xzuYhjmHGYfEGH/w1mvDYtsxJkvxjdijEkrW+9Q8RQjCoeV/a pUUSvTQ3kmaehzhkFCYjBIezEzhtRJJrMRSkyjfoN/JRYFi1KcdgajxMoM3Lmw/x8CaIuoT94Jx1K kE8A0QccedAW01CvNMlV8yVmzmoPnSd9xe6mxVj9PnrIk1DHEVZNB7eMwjvMh1bhH3wgq/cmOEIbm +XJx6IsUUV7dnjNZhRkWd8N4D6wg6xV/W0a7XP7UrSYwTA1aam8Xgr0tTNiYKlN8DzjhcwDujK82l SrUjaoBg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1nTM-00E7ta-3U; Tue, 19 Jan 2021 09:38:54 +0000 Date: Tue, 19 Jan 2021 09:38:48 +0000 From: Christoph Hellwig To: Christian Brauner Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , St??phane Graber , Linus Torvalds , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v5 23/42] open: handle idmapped mounts Message-ID: <20210119093848.GH3364550@infradead.org> References: <20210112220124.837960-1-christian.brauner@ubuntu.com> <20210112220124.837960-24-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112220124.837960-24-christian.brauner@ubuntu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org I think path_permission() and file_persmission() helpers would reduce the clutter a lot here.