Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3309182pxb; Tue, 19 Jan 2021 21:00:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbMIo0KxuiM9ZgFHeNKiNFOCpO8/pLFrNWayo6CeiswDkmj4QO8F3yU83PoSC+nqRYDQSQ X-Received: by 2002:a17:906:a00a:: with SMTP id p10mr5088334ejy.312.1611118840496; Tue, 19 Jan 2021 21:00:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611118840; cv=none; d=google.com; s=arc-20160816; b=McXxY6QbKYaTkSfGZAJSVyQsC1gLBI1sXOkTjJMh8HlKsmrVlTIZt9oFy5AghRxB8j O9mnGh08sevhyQr3EDnNsvZxH8DDw9PyMBsu4dtc9EH9SQ+/aJUyGFEs99I4IRR9fyRe pCuoDPvDtAUFp+omsubrKc2gkY62ZcwWTjZ3+72J3Mjh2rUo2OGejMNLET92lMnkHKBI Lto5LLk6utRof02QuutjnZC6umOz8vm734sM7LDeD/aWPLuwx3vr+Qt9D/78yi7+m2Mn swdGnvIJ7qleeXhbg/Qjb3s2QZDVxUi/0mNLWSV+2qyVP+sCGItV9OBcwDxR1D+0mEH6 SLLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=f97IbnUUUYaVVdsXsEtz94G3i/gpr8Yo4kzXgK2X1XA=; b=xxyV5MMU+sKj6awkbBb3/MzcjdP0ltuPUz4meCEaFFPVJKXj8K+p+IQGHQT7bKKUtg 97N0YEsXB+2NkXfCrCs0d1yQtQcsr4yRdHhmGycbtwEoDx7nMzAHoKpyhZ13C2kSPVCk kAQXd5AleTTx5SLElr80TFpg+4cMpN0Uo3eUBJd04NP5Xbcwc1beAD+cPFCNvRfCMelM 0NtmWdh3QtllW1OfontCCug42ac3XJPcsZyeI6LgFwnRMlO5XmyLENcqtW6b9WqSTztS VAuRQMtrs2nVRVWN7Fp8TdL8zitzljHmO8p+lMOSOizmOlTbV+iLeQNIDHFR5sDHjgu/ 5q2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n5si409819eda.301.2021.01.19.21.00.16; Tue, 19 Jan 2021 21:00:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728558AbhATE7T (ORCPT + 99 others); Tue, 19 Jan 2021 23:59:19 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41360 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729266AbhATE5a (ORCPT ); Tue, 19 Jan 2021 23:57:30 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10K4ufkl022052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Jan 2021 23:56:41 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0289115C35F5; Tue, 19 Jan 2021 23:56:40 -0500 (EST) Date: Tue, 19 Jan 2021 23:56:40 -0500 From: "Theodore Ts'o" To: Lukas Czerner Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] mke2fs: Escape double quotes when parsing mke2fs.conf Message-ID: References: <20201102142631.87627-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102142631.87627-1-lczerner@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 02, 2020 at 03:26:31PM +0100, Lukas Czerner wrote: > Currently, when constructing the configuration pseudo-file using > the profile-to-c.awk script we will just pass the double quotes as they > appear in the mke2fs.conf. > > This is problematic, because the resulting default_profile.c will either > fail to compile because of syntax error, or leave the resulting > configuration invalid. Applied, thanks. - Ted