Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 23:55:26 -0500
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Romain Naour <romain.naour@gmail.com>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: add gnu.translator support
Message-ID: <YAe3voa3OCFbtSoc@mit.edu>
References: <20201102130319.1434330-1-romain.naour@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201102130319.1434330-1-romain.naour@gmail.com>
Precedence: bulk

On Mon, Nov 02, 2020 at 02:03:19PM +0100, Romain Naour wrote:
> The support of setting (and reading) of passive translators from
> GNU/Linux has been added to the Linux kernel by the commit [1].
> The name index '10' has been reserved for GNU/Hurd.
> 
> Hurd passive translators are stored as a xattr value with name
> "gnu.translator" [2].
> 
> If "gnu.translator" xattr value has been set before calling
> mkfs.ext2, it will segfault since "gnu." is not present in
> ea_names[].
> 
> $ setfattr -n gnu.translator -v "/hurd/exec\0" ${TARGET_DIR}/servers/exec
> $ mkfs.ext2 -d ${TARGET_DIR} -o hurd -O ext_attr rootfs.ext2 "1G"
> 
> Adding "gnu." to ea_names[], allow to create ext2 filesystem
> for GNU/Hurd with passive translator already set.
> 
> [1] https://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=a04c7bf83172faa7cb080fbe3b6c04a8415ca645
> [2] https://lists.gnu.org/archive/html/bug-hurd/2016-08/msg00075.html
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Theodore Ts'o <tytso@mit.edu>

Applied, thanks.

					- Ted