Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp364295pxb; Thu, 21 Jan 2021 08:52:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzryWbeul/bW6AKsra8xWVbAd7rUn1NqCNMIL1F/xVt0edaOoWjqOxOkWW1edPa7zRt04Ya X-Received: by 2002:aa7:d88e:: with SMTP id u14mr56733edq.72.1611247956490; Thu, 21 Jan 2021 08:52:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611247956; cv=none; d=google.com; s=arc-20160816; b=n4d1B4lEQTR9dnEqJjsqlAAqRr3QUSlLCfXPeUUBldPxSGIJ84A7lgAyKwZdfZuwoR YuS+XGz9AIiiKs9bEv5zrelBni4fTNexCbYjmwJB4lM70KXCsMo1s2rfU1D8on1gdNoS Y+Omi/c+HFa6x5dj0UwALKc/hgo2NaDk0gUe+RscN8VeyAXATBf1mtfquJcmLrRUrf+4 LYnBivfLzIj8vBRsxgoG2RDPNnN2bwrrr2XNSa5gF9G7cv/yYEzvHueG4VhnGxumUzKw OW+bvxFeejdAu1IBqsxbj0stI7dQa5KMtzCeWuoS70QsffBiIVd/xPx1GvC9SfzzA8Qo iNaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=7WBIo0w5nqqHSHNgV63semQ+Kbi0iLqMLnoZLodB0bQ=; b=mfNnZmQREn4B9ig6fp4hCFvDqdFFswoHiopG5WhHmPoze44OvAdzalQcPvijdnDB83 D1K4Kwta7FjIxTm4rbjVVSP0p1RYXnuVjkG+TLcXKpNz4SQrLHSa/z0wxLSUeWGpvtAK kOZ2BFWABJnjXemu/TiN79T2NUgWhNf5APtwJBiGCOAIdwEam+GsmN+L5oxrgNL4OpX/ S1drvPxTzSYozcDs7voVv3899YmnquYMjMcoMbO1txB1wcQkw1rfTmBkWjund9igNW3e +FxJDa9O95CQy8Ecg8iy/Rv3FYoM2w7m721pmLnkBi5PSD/HOw/ZSlJlDXqeUBDlm7E8 lm8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si2447310edy.514.2021.01.21.08.52.12; Thu, 21 Jan 2021 08:52:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731961AbhAUQur (ORCPT + 99 others); Thu, 21 Jan 2021 11:50:47 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41758 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388168AbhAUQuq (ORCPT ); Thu, 21 Jan 2021 11:50:46 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10LGnwaL026890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 11:49:58 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EEFE815C35F5; Thu, 21 Jan 2021 11:49:57 -0500 (EST) Date: Thu, 21 Jan 2021 11:49:57 -0500 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 13/15] debugfs: add fast commit support to logdump Message-ID: References: <20210120212641.526556-1-user@harshads-520.kir.corp.google.com> <20210120212641.526556-14-user@harshads-520.kir.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120212641.526556-14-user@harshads-520.kir.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 20, 2021 at 01:26:39PM -0800, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > Add fast commit support for debugfs logdump. The debugfs output looks > like this: I've applied this patch set, with slight changes. In particular this commit relies on lib/ext2fs/fast_commit.h which is byte-for-byte identical with the kernel fast_commit.h, and which originally added in patch #8 of this series ("e2fsck: add fast commit setup code"), so I've added that file to this commit. - Ted