Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp365717pxb; Thu, 21 Jan 2021 08:54:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPuCkVsvIIhJzahqEtqRhTmWfkTzGPAp+bQYtAcMgy7IRvRI9osKx79+BVhdMkD+bAin8S X-Received: by 2002:a50:becf:: with SMTP id e15mr59007edk.138.1611248087454; Thu, 21 Jan 2021 08:54:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611248087; cv=none; d=google.com; s=arc-20160816; b=GRyOBQguUwfVOq8jcPDIbbf5Apd1SFzlwrVgSTLwvhMQFtkZMWFwOyAUW30XCcXQwg i/YE6YNvQDYndbMjhWTV2Kd6pWl9KhYyj0snZVRdbP6ASMfsveXx09Ndkmr89Z0zQBoz W5aM5GFufMXEOhVz53HtB5Lsncmbrpwhb6JyI3HVTBB1s0kDtYyEs64aBb4iRqINV1+w xU64XhCegLnwDuoA7ubgu3x4QnWyr6sXrDkAV4QgmQff626IqsRqg3woS/WuJPKsoC0g kgvFKXKGXLUwdzZLo6CDI6QC7VjBSnkzJwQasgDasFdnoXrmtQ4LpIh3bdkRQdvvtrOq k+xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=RvVX64pEP1+nEHs8wrXYbhA6nnKMKaUBIM1cOYiTg4Q=; b=eGhSOLphwenDcb4y3aft+gFmi1MndFsoIq6G/xPvyFWfzvUrpYULx8qxt35z32gW0h vOJhJKLssZTgHOAa8X2wjd4oNa31u4aOAi6UJsvmRPzw4IZQ4j3VY5StL/M/wIgPtVRd taUzAWNljn5/xyQdYJvzioRB9FyXH8H09RLlRoN+ARo6vZHk4CYn1+hZNtfryZ+N1nnv iXLHs9rQJHPV8p5Jb/piJnhTQeOTS1+V6MUO2r2iK/YZVQyrWZq7Ga0zMmBuckzesMDa FsXdSJM1U422Wjvc/G1tKl/98sduqhipaJYyvnYqu9ykKlWJHoGhnoD2latXxEiwOthC 8gww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si2356293edx.601.2021.01.21.08.54.24; Thu, 21 Jan 2021 08:54:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388179AbhAUQxo (ORCPT + 99 others); Thu, 21 Jan 2021 11:53:44 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58264 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729088AbhAUPyt (ORCPT ); Thu, 21 Jan 2021 10:54:49 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10LFs0Ja002686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 10:54:00 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 468F215C35F5; Thu, 21 Jan 2021 10:54:00 -0500 (EST) Date: Thu, 21 Jan 2021 10:54:00 -0500 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 01/15] ext2fs: move calculate_summary_stats to ext2fs lib Message-ID: References: <20210120212641.526556-1-user@harshads-520.kir.corp.google.com> <20210120212641.526556-2-user@harshads-520.kir.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120212641.526556-2-user@harshads-520.kir.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 20, 2021 at 01:26:27PM -0800, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > The function calculate_summary_stats sets the global metadata of the > file system. Tune2fs had this function defined statically in > tune2fs.c. Fast commit replay needs this function to set global > metadata at the end of the replay phase. So, move this function to > libext2fs. > > Signed-off-by: Harshad Shirwadkar > Reviewed-by: Theodore Ts'o Thanks, applied. - Ted