Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp609512pxb; Thu, 21 Jan 2021 15:28:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzI/70BxSYr/7U6XQkSUpB4bRMOvxqSolrEM5xQtBOBH2F+GtZN6D6OjzDrA+o3fJ/CEwuc X-Received: by 2002:aa7:d610:: with SMTP id c16mr1198638edr.354.1611271732014; Thu, 21 Jan 2021 15:28:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611271732; cv=none; d=google.com; s=arc-20160816; b=J5Ylf2Ut7R08NaAzej3WiCOuiS0Q+5wycoYUrRGm1CGEVkean9odTqMAKclfjYz9AE mGLV92qL19HzQ87r7gJxrlxmtXN15uuB06ImVZMoT0USMuIG1eFtMBqTnAaWQZreqGeC Tj83WB+dY31yg08XlPLAoFjHx+QXplW/RUFN5ISmECfRnjbxV/pT6NvsQr+1mTeHQnw4 ybWxvAHRRk41VzZCnQD+IeMIn2Pi/HGpYhdrTt2c6K7RusnqMA4FQ4AlNO0GjCLKxO1u D+WF+al+rJZIqHC3Ac4At7IFFpCjgBTFVmU5c1a7lk1CC2xL0qROgf0zr3nkcPIelIV/ TxBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=GZ47b2u5I1Sw5KVZBcQP44HrNtRf4x0jQR1SmLmgCT8=; b=C1M1mbKtLn+mijvenZaQq8NQRowuqKeFVQHkNYpZ+tG2p78fpSzokub9v5HW/O329W OatskBZWBKAjGkP2NPJpLY+y4GApPiZCqbvf4UE06NkLkbSda8jsxaQ1wswPF5KyXYVA azoa1Fs2lEbzn2285QVlgn4VAPxOTPJ+C5wqiGMh9jwh6jD4K+DAcJBcyiMRYzH/7sai /4wzRg4uNSTvB2k/wPuPo0lNmIw9n/5xyTzCE/h76J6vKYFMrOPFt/9iwTlpGSiSMsxd O2u3VB0Yw2gdaa2JZR+bGYe+gRsR6YT0DAIgEC3K4smauguWRiGRPRtL2UdDsISZ04ir Aw7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si2899233edn.453.2021.01.21.15.28.28; Thu, 21 Jan 2021 15:28:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbhAUX0s (ORCPT + 99 others); Thu, 21 Jan 2021 18:26:48 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40444 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726179AbhAUX0Z (ORCPT ); Thu, 21 Jan 2021 18:26:25 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10LNPSAr025808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 18:25:29 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id ADBEC15C35F5; Thu, 21 Jan 2021 18:25:28 -0500 (EST) Date: Thu, 21 Jan 2021 18:25:28 -0500 From: "Theodore Ts'o" To: Hauke Mehrtens Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH e2fsprogs] build: Add SYSLIBS to e4crypt linking Message-ID: References: <20201215230557.17211-1-hauke@hauke-m.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201215230557.17211-1-hauke@hauke-m.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Dec 16, 2020 at 12:05:57AM +0100, Hauke Mehrtens wrote: > The $(SYSLIBS) was missing when linking the e4crypt application. This is > available in the e4crypt.profiled variant, so I assume this was just > missing in the normal variant and is not left out intentionally. Thanks, I've applied. It was left out unintentionally, although I don't see how this is affecting building e2fsprogs with -fsanitize=undefined in the global CFLAGS and LDFLAGS. (Which worked for me both before and after applying this change.) - Ted