Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp610604pxb; Wed, 27 Jan 2021 16:42:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHj0ZL6o5Y+k7jyNn0CGMn9epZ6vaS7nT56YdiuYWpiKMCKHSVEYFdErq8IfLChwiUbShg X-Received: by 2002:a50:8004:: with SMTP id 4mr11274150eda.155.1611794520572; Wed, 27 Jan 2021 16:42:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611794520; cv=none; d=google.com; s=arc-20160816; b=iJSRXVCVnl+udIZtCeH4jwhAsQnaF3MYkoCrgGfWmDiWsp4rbQjGwJYr38L+AtPT12 tT1MTmYRWk/csTvksdPWt5R6YO4+MWFEMHLVh9oi7trhPzx/mGMUqIGdw8gKFa5OFWXl 9ITR28PhTCeWGJDP7Dbs8jlPoZBUMQFmWG1ol/YHRuLAT0BjHsd5YgzLjdBLq0D3UvKN 57qw20ZheEkJlFv5b4pSA9kvX08RqFn9ygFSDjtXcK8yC3OzcPXb4u5s/U+hujvaMgNj dVcJiJj7T1fxC0njtl4HVuveEYdFu+1lUuY34iYyjV9uT+dDAog30dGK1DwVGWGytDFM x8yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=tMP0ev7poG6tUhdjSvta2Qd0hMX4lg2ZvIvXHJNDYrk=; b=aq0pfgxARWKACcwDjx+X4ng4nPxcUCBex8R/2SxC9jFbEmmuuzOxHhIfO+HhMzJVe1 6xnftk8h2hdk03hY20j/zwK3e/pWWck3Q3jnqg/zho76t4JWkufm66WIWa2+p46Q/BIM 66qUWzpzTbX2ufkzFdJUzRSpj2nZxEXAp+wxykypYe9MrQ5JtY4n94six5ESR2fXL/jr NrekqLQHJOlSfm+XO7VJ9cbhoewMk0zngWtAPQv2rWpSRmIdbZMZ8RSZlgkrIfw287N1 ov6fTHLdk0kdhXm6vbZ0YkzwZU7Xgy2Muup5urwZ/UbcNdbmMu4f8RLqT4CukHDK+DTL E2AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id he44si1628197ejc.386.2021.01.27.16.41.36; Wed, 27 Jan 2021 16:42:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231563AbhA0Wwz (ORCPT + 99 others); Wed, 27 Jan 2021 17:52:55 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58210 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230526AbhA0Wwv (ORCPT ); Wed, 27 Jan 2021 17:52:51 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10RMgcgv029032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 17:42:39 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6779915C344F; Wed, 27 Jan 2021 17:42:38 -0500 (EST) Date: Wed, 27 Jan 2021 17:42:38 -0500 From: "Theodore Ts'o" To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, krisman@collabora.com, ebiggers@kernel.org Subject: Re: [PATCH RESEND v2 01/12] tune2fs: Allow enabling casefold feature after fs creation Message-ID: References: <20201210150353.91843-1-arnaud.ferraris@collabora.com> <20201210150353.91843-2-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210150353.91843-2-arnaud.ferraris@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 10, 2020 at 04:03:42PM +0100, Arnaud Ferraris wrote: > From: Gabriel Krisman Bertazi > > The main reason we didn't allow this before was because !CASEFOLDED > directories were expected to be normalized(). Since this is no longer > the case, and as long as the encrypt feature is not enabled, it should > be safe to enable this feature. > > Disabling the feature is trickier, since we need to make sure there are > no existing +F directories in the filesystem. Leave that for a future > patch. > > Also, enabling strict mode requires some filesystem-wide verification, > so ignore that for now. > > Signed-off-by: Gabriel Krisman Bertazi > Signed-off-by: Arnaud Ferraris Thanks, applied. - Ted