Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp676288pxb; Wed, 27 Jan 2021 18:51:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJycLiD6lq+HkqDtwWNQs+qaB3L1kWd1scfwYtP+7jzaG1sf32J3miCkr5TCXMNOPZMdFJZQ X-Received: by 2002:a50:9f4d:: with SMTP id b71mr11958385edf.310.1611802282329; Wed, 27 Jan 2021 18:51:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611802282; cv=none; d=google.com; s=arc-20160816; b=q3L7+9pevXn37NuGFOtc/uNfYDQUXuWrtHgshFBmqsAhgCOjm8DtTYzcyXPxesJiie LfFe7DUjeudr594kHajyc76w8PdZzFK6R/Tp92MVLlCrA+NImOC4lH49NfOv9UyK7iWe Hffvqd6PIM1Gj0xz+LirUzXDYaJ3ZHuzlaKj30cjVfck+DRuNGKJbnMA7Ra4iHxLJJYh hoj1J76jpn3jpeo1rCWbBSO2nJmFQq7AaOanZh5zIQKQ2YB3bFFMMvqcjub8gf5/ln+w nJL2kXAl2QQ2I23nPNWOryXPTMLdAUuv1oAc91BOHSUkrGdqfwi8kNeRxZudGQ/jXDsn 2FNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=eyT4eWY9IkvwlXb0ZuhlUCtHv31Korhu3tskdynf0RU=; b=NlPj/qwE/qRMkfUwgIlYnToDdVZDRl9CoDOjrtEUXWK7RK01vXe2M+snaPquWLGnJU 7T5G9a/BRChCcNHIQgcI4MwvytR2NZScaNlHjPuOioxdWHeY7aAobuL8GbqYlQBkgo7F DT/Id779Vu1YR4hfBpzGFuo+p66T6CiRKlpRTq84s1dxKYL7oFplGlN3BGh76NCSeCgu oSNdNOsBm5yaFSODoUKK5sJ8vo85AASdAxxNipQsIsVjt/ytOKxu20PiYH4ZEV1pIZWG BDjvKrCT+XMoMEk69TMisMHYMD/P8cHpQ2FWrBtv6ap+SPyRkBBgag5/BpBgXn9dntDA gP+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si44859edm.453.2021.01.27.18.50.58; Wed, 27 Jan 2021 18:51:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhA1CuW (ORCPT + 99 others); Wed, 27 Jan 2021 21:50:22 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38557 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229494AbhA1CuW (ORCPT ); Wed, 27 Jan 2021 21:50:22 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10S2nSX6015041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 21:49:28 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EC92715C344F; Wed, 27 Jan 2021 21:49:27 -0500 (EST) Date: Wed, 27 Jan 2021 21:49:27 -0500 From: "Theodore Ts'o" To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, krisman@collabora.com, ebiggers@kernel.org Subject: Re: [PATCH RESEND v2 04/12] ext2fs: Implement faster CI comparison of strings Message-ID: References: <20201210150353.91843-1-arnaud.ferraris@collabora.com> <20201210150353.91843-5-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210150353.91843-5-arnaud.ferraris@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 10, 2020 at 04:03:45PM +0100, Arnaud Ferraris wrote: > From: Gabriel Krisman Bertazi > > Instead of calling casefold two times and memcmp the result, which > require allocating a temporary buffer for the casefolded version, add a > strcasecmp-like method to perform the comparison of each code-point > during the casefold itself. > > This method is exposed because it needs to be used directly by fsck. > > Signed-off-by: Gabriel Krisman Bertazi > Signed-off-by: Arnaud Ferraris Thanks, applied. - Ted