Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp680934pxb; Wed, 27 Jan 2021 19:02:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcTbmNK271AQUs/HQmR4vnHT565lQfWPLxFI2uYU00veZmSgZWDEXz6OQFUVrCbk1+2qof X-Received: by 2002:a50:e0c1:: with SMTP id j1mr11593509edl.253.1611802951178; Wed, 27 Jan 2021 19:02:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611802951; cv=none; d=google.com; s=arc-20160816; b=s0/D9eNHhpOUsj4kpuuixu8RVfc+gQZ1+IqcLEo0tcvM3Kd8+b9UgFPKyHt9MsydNw QRe8TEhs4NBEnrT+r3EZel2i+XTYZ2W7yD8XqGqw/DbZ1iKDYvR00rIPHIlBkUv4P20+ zDI7YvS/OQ/eL3rr5e9LZTXpdIyQ5c7CyFqh7aDuAZexMQ6TF+Pgzu4NfTBSiFYk5PRR GlKIVvIJZm15cHJqn8Gs45F/41+dtdUchOk8X1DT3ABGnjGoE4i8+zgltd1hKGDPcgyy KHBe9xMBU99gfoX3wXTzO1be3YNXfhBXCQ9MYVtyU9UWOY7SD9EnRZCX5OO5zCcZhuxp Ep2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=n5LoZYDUIWHg0aKHm8DbnxyLMbySPIp36aNmZAC09jg=; b=x9BaGtfNOBn3VFz49HJfoXtXNqBLE9fVR3iSyEQtDgqwnE3ZhJn07FJTqyW2qN8tYs 1S2btJhOZCHYTk9+eJE+v1Y8mc6l89TjRmlDZU0fGDjg6Glgnbyo+JVedTSK22h/1aAP vKzSwiLEg4z5ikCC5asjAaSw87MZezqM0yBIwP3bvuRhJOFQwkBC+PJ0cK+TDdlCxPQo qS6R65BX9cdkMoIEIZdKXcCHdSj88ue1n/VIfzjhPsoCf+XAegbG9x+uQ+O1Es79A66e 82H1O1YM4hWiczbaBPNGpWELUrbNlrU+T342DIvU16FeDA+NxITeQg+4Lw7+qYiVMpeL DTOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si2203873edd.343.2021.01.27.19.02.06; Wed, 27 Jan 2021 19:02:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhA1C7W (ORCPT + 99 others); Wed, 27 Jan 2021 21:59:22 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39731 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229682AbhA1C7U (ORCPT ); Wed, 27 Jan 2021 21:59:20 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10S2wS8l017691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 21:58:28 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 465BF15C344F; Wed, 27 Jan 2021 21:58:28 -0500 (EST) Date: Wed, 27 Jan 2021 21:58:28 -0500 From: "Theodore Ts'o" To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, krisman@collabora.com, ebiggers@kernel.org Subject: Re: [PATCH v3 01/12] tune2fs: Allow enabling casefold feature after fs creation Message-ID: References: <20201217173544.52953-1-arnaud.ferraris@collabora.com> <20201217173544.52953-2-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217173544.52953-2-arnaud.ferraris@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 17, 2020 at 06:35:33PM +0100, Arnaud Ferraris wrote: > From: Gabriel Krisman Bertazi > > The main reason we didn't allow this before was because !CASEFOLDED > directories were expected to be normalized(). Since this is no longer > the case, and as long as the encrypt feature is not enabled, it should > be safe to enable this feature. > > Disabling the feature is trickier, since we need to make sure there are > no existing +F directories in the filesystem. Leave that for a future > patch. > > Also, enabling strict mode requires some filesystem-wide verification, > so ignore that for now. > > Signed-off-by: Gabriel Krisman Bertazi > Signed-off-by: Arnaud Ferraris Thanks, applied. - Ted